[Athena] Copy implementation of some ExtensionTabUtil methods.

[Athena] Copy implementation of some ExtensionTabUtil methods.

Fixes sign in bug (white screen and no way to proceed) with https://codereview.chromium.org/473153002/

BUG=426855
Committed: https://crrev.com/f61de3e9a6142a5626262e528eb73ad2b083a4b2
Cr-Commit-Position: refs/heads/master@{#301609}

[Nikita (slow), 2014-10-24 13:41:04]

nkostylev@chromium.org changed reviewers:
+ oshima@chromium.org

[Nikita (slow), 2014-10-24 13:41:04]

Oshima, please suggest whether this is acceptable way to proceed since I'm now
relanding https://codereview.chromium.org/473153002/ and it breaks sign in on
Chrome OS.

[oshima, 2014-10-24 14:41:26]

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tab_util_athena.cc (right):

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tab_util_athena.cc:236: for
(chrome::BrowserIterator it; !it.done(); it.Next()) {
 there is no browser / tabstrip in athena.  how does this work?

[Nikita (slow), 2014-10-24 15:10:47]

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tab_util_athena.cc (right):

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tab_util_athena.cc:236: for
(chrome::BrowserIterator it; !it.done(); it.Next()) {
On 2014/10/24 14:41:26, oshima wrote:
>  there is no browser / tabstrip in athena.  how does this work?

I need to double check, maybe this method is not needed though for this
particular bug.

[Nikita (slow), 2014-10-27 10:56:50]

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tab_util_athena.cc (right):

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tab_util_athena.cc:110: WindowController*
controller = GetAppWindowController(contents);
I've removed impl for this method as well cause it's not really needed for this
fix.

https://codereview.chromium.org/642693003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tab_util_athena.cc:236: for
(chrome::BrowserIterator it; !it.done(); it.Next()) {
On 2014/10/24 15:10:47, Nikita Kostylev wrote:
> On 2014/10/24 14:41:26, oshima wrote:
> >  there is no browser / tabstrip in athena.  how does this work?
> 
> I need to double check, maybe this method is not needed though for this
> particular bug.

This method is not really needed for a fix, removed.

[oshima, 2014-10-27 13:44:38]

https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/extension_tab_util_athena.cc (right):

https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/extension_tab_util_athena.cc:118: TabStripModel*
tab_strip,
do you know who/where creates tab_strip on athea? What's in it?

[Nikita (slow), 2014-10-27 15:07:27]

https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/extension_tab_util_athena.cc (right):

https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/extension_tab_util_athena.cc:118: TabStripModel*
tab_strip,
On 2014/10/27 13:44:38, oshima wrote:
> do you know who/where creates tab_strip on athea? What's in it?
> 

It's actually passed as NULL.

[oshima, 2014-10-27 15:09:38]

On 2014/10/27 15:07:27, Nikita Kostylev wrote:
>
https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
> File chrome/browser/extensions/extension_tab_util_athena.cc (right):
> 
>
https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
> chrome/browser/extensions/extension_tab_util_athena.cc:118: TabStripModel*
> tab_strip,
> On 2014/10/27 13:44:38, oshima wrote:
> > do you know who/where creates tab_strip on athea? What's in it?
> > 
> 
> It's actually passed as NULL.

If it's always NULL, can you do check/dcheck and remove unnecessary code?

[Nikita (slow), 2014-10-27 15:36:52]

On 2014/10/27 15:09:38, oshima wrote:
> On 2014/10/27 15:07:27, Nikita Kostylev wrote:
> >
>
https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
> > File chrome/browser/extensions/extension_tab_util_athena.cc (right):
> > 
> >
>
https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
> > chrome/browser/extensions/extension_tab_util_athena.cc:118: TabStripModel*
> > tab_strip,
> > On 2014/10/27 13:44:38, oshima wrote:
> > > do you know who/where creates tab_strip on athea? What's in it?
> > > 
> > 
> > It's actually passed as NULL.
> 
> If it's always NULL, can you do check/dcheck and remove unnecessary code?

Do you think it makes sense to remove NOTIMPLEMENTED() from
ExtensionTabUtil::GetTabStripModel() too?
Or do you think it will be implemented eventually?

[Nikita (slow), 2014-10-27 15:44:36]

On 2014/10/27 15:09:38, oshima wrote:
> On 2014/10/27 15:07:27, Nikita Kostylev wrote:
> >
>
https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
> > File chrome/browser/extensions/extension_tab_util_athena.cc (right):
> > 
> >
>
https://codereview.chromium.org/642693003/diff/40001/chrome/browser/extension...
> > chrome/browser/extensions/extension_tab_util_athena.cc:118: TabStripModel*
> > tab_strip,
> > On 2014/10/27 13:44:38, oshima wrote:
> > > do you know who/where creates tab_strip on athea? What's in it?
> > > 
> > 
> > It's actually passed as NULL.
> 
> If it's always NULL, can you do check/dcheck and remove unnecessary code?

done.

[oshima, 2014-10-27 18:12:15]

lgtm

[Nikita (slow), 2014-10-27 18:17:45]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-10-27 18:19:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642693003/80001

[commit-bot: I haz the power, 2014-10-27 18:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 18:28:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2014-10-27 20:10:47]

nkostylev@chromium.org changed reviewers:
+ benwells@chromium.org

[Nikita (slow), 2014-10-27 20:10:48]

+benwells@ for owners review.

[Nikita (slow), 2014-10-27 20:12:29]

longterm hashimoto@ is working on refactoring so that we can share the code as
much as possible.

[Nikita (slow), 2014-10-28 09:34:30]

nkostylev@chromium.org changed reviewers:
+ finnur@chromium.org

[Nikita (slow), 2014-10-28 09:35:12]

+finnur@ as well (trying to catch someone from owners)

There's a bug that prevents new user sign in on Athena builds.

[Finnur, 2014-10-28 09:57:32]

OWNERS LGTM

[Nikita (slow), 2014-10-28 10:58:10]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-10-28 11:00:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642693003/80001

[commit-bot: I haz the power, 2014-10-28 12:01:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-28 12:01:47]

Patchset 5 (id:??) landed as
https://crrev.com/f61de3e9a6142a5626262e528eb73ad2b083a4b2
Cr-Commit-Position: refs/heads/master@{#301609}