[WebMIDI] Remove not needed CancelPermission IPC message.

[WebMIDI] Remove not needed CancelPermission IPC message.

BUG=421085
Committed: https://crrev.com/97ae1b0f4295e1b47e8bb76e09ae85bb854fb546
Cr-Commit-Position: refs/heads/master@{#298986}

[mlamouri (slow - plz ping), 2014-10-09 12:46:57]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[mlamouri (slow - plz ping), 2014-10-09 12:46:58]

jochen@chromium.org: Please review changes in 
 content/
mkwst@chromium.org: Please review changes in 
 content/common/media/midi_messages.h

[mlamouri (slow - plz ping), 2014-10-09 12:47:36]

https://codereview.chromium.org/642623005/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_dispatcher.cc (left):

https://codereview.chromium.org/642623005/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_dispatcher.cc:54: // the blink MIDIAccessInitializer
object is deleted.
That doesn't seem to be true.

[Mike West, 2014-10-09 13:07:39]

Dropping the message LGTM.

https://codereview.chromium.org/642623005/diff/1/content/browser/media/midi_d...
File content/browser/media/midi_dispatcher_host.cc (right):

https://codereview.chromium.org/642623005/diff/1/content/browser/media/midi_d...
content/browser/media/midi_dispatcher_host.cc:97: for (size_t i = 0; i <
pending_permissions_.size(); ++i) {
Nit: If you like, you could convert this to an awesome new range-based C++11
loop to avoid the index.

[mlamouri (slow - plz ping), 2014-10-09 13:21:43]

https://codereview.chromium.org/642623005/diff/1/content/browser/media/midi_d...
File content/browser/media/midi_dispatcher_host.cc (right):

https://codereview.chromium.org/642623005/diff/1/content/browser/media/midi_d...
content/browser/media/midi_dispatcher_host.cc:97: for (size_t i = 0; i <
pending_permissions_.size(); ++i) {
On 2014/10/09 13:07:38, Mike West wrote:
> Nit: If you like, you could convert this to an awesome new range-based C++11
> loop to avoid the index.

The index is used for erase. I could change the code to use an iterator instead
of an index but I'm not sure it's worth it.

[Mike West, 2014-10-09 13:25:05]

On 2014/10/09 13:21:43, Mounir Lamouri wrote:
> The index is used for erase. I could change the code to use an iterator
instead
> of an index but I'm not sure it's worth it.

You're right. I didn't see the call at the bottom. Nevermind!

[mlamouri (slow - plz ping), 2014-10-09 16:23:44]

mlamouri@chromium.org changed reviewers:
+ creis@chromium.org

[mlamouri (slow - plz ping), 2014-10-09 16:23:44]

+creis@ in case of he can review that today (probably too late for jochen@ now)

[Charlie Reis, 2014-10-09 17:11:31]

LGTM

https://codereview.chromium.org/642623005/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_dispatcher.cc (left):

https://codereview.chromium.org/642623005/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_dispatcher.cc:54: // the blink MIDIAccessInitializer
object is deleted.
On 2014/10/09 12:47:36, Mounir Lamouri wrote:
> That doesn't seem to be true.

Sad that there's no test for this class to catch that.  Feel free to add one if
it's easy, but I won't block this CL for it.

[mlamouri (slow - plz ping), 2014-10-09 21:33:50]

https://codereview.chromium.org/642623005/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_dispatcher.cc (left):

https://codereview.chromium.org/642623005/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_dispatcher.cc:54: // the blink MIDIAccessInitializer
object is deleted.
On 2014/10/09 17:11:31, Charlie Reis wrote:
> On 2014/10/09 12:47:36, Mounir Lamouri wrote:
> > That doesn't seem to be true.
> 
> Sad that there's no test for this class to catch that.  Feel free to add one
if
> it's easy, but I won't block this CL for it.

Having the |request| pending would only have it leaked until the renderer is
destroyed. Not a terrible thing. Also, testing that might require a browser test
which is some kind of heavy artillery given the benefits.

[mlamouri (slow - plz ping), 2014-10-09 21:33:55]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-10-09 21:36:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642623005/1

[commit-bot: I haz the power, 2014-10-09 21:51:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-09 21:52:27]

Patchset 1 (id:??) landed as
https://crrev.com/97ae1b0f4295e1b47e8bb76e09ae85bb854fb546
Cr-Commit-Position: refs/heads/master@{#298986}