Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2242)

Unified Diff: chrome/browser/history/history_backend.h

Issue 642623004: Rename VisitDatabaseObserver to HistoryServiceObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@373326
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/chrome_history_client.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index 47d8136438750813e6ed494edf4bf64bd870246f..1c879803f11a030f37f21bddfaf35deaf3c5a600 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -125,12 +125,16 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
virtual void NotifyFaviconChanged(const std::set<GURL>& urls) = 0;
// Notify HistoryService that the user is visiting an URL. The event will
- // be forwarded to the HistoryServiceObservers in the correct thread.
+ // be forwarded to the HistoryService::Observers in the correct thread.
virtual void NotifyURLVisited(ui::PageTransition transition,
const URLRow& row,
const RedirectList& redirects,
base::Time visit_time) = 0;
+ // Notify HistoryService that VisitDatabase was changed. The even will be
blundell 2014/10/09 12:02:22 event
sdefresne 2014/10/13 17:27:03 Done.
+ // forwarded to the HistoryService::Observers in the correct thread.
+ virtual void NotifyAddVisit(const history::BriefVisitInfo& info) = 0;
+
// Broadcasts the specified notification to the notification service.
// This is implemented here because notifications must only be sent from
// the main thread. This is the only method that doesn't identify the
@@ -140,9 +144,6 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// Invoked when the backend has finished loading the db.
virtual void DBLoaded() = 0;
-
- virtual void NotifyVisitDBObserversOnAddVisit(
- const history::BriefVisitInfo& info) = 0;
};
// Init must be called to complete object creation. This object can be
« no previous file with comments | « chrome/browser/history/chrome_history_client.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698