Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 642623002: Move passphrase dialog logic to the enum. (Closed)

Created:
6 years, 2 months ago by maxbogue
Modified:
6 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@passphrase
Project:
chromium
Visibility:
Public.

Description

Move passphrase dialog logic to the enum. In preparation for a bug fix. BUG=419927 Committed: https://crrev.com/cd77acb3d1dc9c4f5e813b6f8239915b06a6cdde Cr-Commit-Position: refs/heads/master@{#298900}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary prefixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java View 1 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
maxbogue
6 years, 2 months ago (2014-10-08 22:39:31 UTC) #2
nyquist
lgtm with comment https://codereview.chromium.org/642623002/diff/1/sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java File sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java (right): https://codereview.chromium.org/642623002/diff/1/sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java#newcode65 sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java:65: visibleTypes.add(SyncDecryptionPassphraseType.CUSTOM_PASSPHRASE); Do you need to have ...
6 years, 2 months ago (2014-10-08 22:41:45 UTC) #3
maxbogue
https://codereview.chromium.org/642623002/diff/1/sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java File sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java (right): https://codereview.chromium.org/642623002/diff/1/sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java#newcode65 sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java:65: visibleTypes.add(SyncDecryptionPassphraseType.CUSTOM_PASSPHRASE); On 2014/10/08 22:41:45, nyquist wrote: > Do you ...
6 years, 2 months ago (2014-10-08 22:52:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642623002/20001
6 years, 2 months ago (2014-10-09 15:58:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9fa2412428c69a38cd20bc7c0c21f6215f2113c2
6 years, 2 months ago (2014-10-09 16:30:37 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 16:31:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd77acb3d1dc9c4f5e813b6f8239915b06a6cdde
Cr-Commit-Position: refs/heads/master@{#298900}

Powered by Google App Engine
This is Rietveld 408576698