Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 642613002: Use Sync FakeServer in exponential backoff tests (Closed)

Created:
6 years, 2 months ago by pval...(no longer on Chromium)
Modified:
6 years, 2 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use Sync FakeServer in exponential backoff tests For SyncExponentialBackoffTest.OfflineToOnline, methods were added to simulate and reset a network failure. The old (Python server) way of doing this has been deleted from SyncTest. For SyncExponentialBackoffTest.TransientErrorTest, a TRANSIENT_ERROR is now triggered on FakeServer. The old way of doing this, SyncTest.TriggerTransientError(), has been deleted. BUG=406545 Committed: https://crrev.com/b1d8faa07507442e41c8a8a39217bcd2311b07fa Cr-Commit-Position: refs/heads/master@{#299034}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -89 lines) Patch
M chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 4 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 5 chunks +0 lines, -63 lines 0 comments Download
M sync/test/fake_server/fake_server.h View 2 chunks +11 lines, -0 lines 0 comments Download
M sync/test/fake_server/fake_server.cc View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pval...(no longer on Chromium)
6 years, 2 months ago (2014-10-08 23:14:03 UTC) #4
pavely
lgtm
6 years, 2 months ago (2014-10-09 01:01:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642613002/40001
6 years, 2 months ago (2014-10-09 23:33:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years, 2 months ago (2014-10-10 01:37:56 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:05:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1d8faa07507442e41c8a8a39217bcd2311b07fa
Cr-Commit-Position: refs/heads/master@{#299034}

Powered by Google App Engine
This is Rietveld 408576698