Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 642603006: X87: Implement the new semantics for 'super(...)' (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Implement the new semantics for 'super(...)' original commit message: Implement the new semantics for 'super(...)' Per the latest ES6 draft, super(...) translates into a call to function's prototype. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
WL. PTAL.
6 years, 2 months ago (2014-10-20 01:31:23 UTC) #2
Weiliang
lgtm
6 years, 2 months ago (2014-10-20 02:00:38 UTC) #3
Weiliang
Committed as r24711
6 years, 2 months ago (2014-10-20 02:01:40 UTC) #4
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-20 06:57:25 UTC) #5
On 2014/10/20 02:01:40, Weiliang wrote:
> Committed as r24711

lgtm, closing issuel

Powered by Google App Engine
This is Rietveld 408576698