Don't UseCounter CSS properties on recursive parseValue calls

Don't UseCounter CSS properties on recursive parseValue calls

Currently we count CSS properties in CSSPropertyParser::parseValue (the
non-static version). This function is used recursively for shorthands,
so we end up tracking many CSS properties which haven't been specified
by users.

This patch moves the check up a level, so that it is only called on
properties specified by a user. I've also made it only count properties
that succeeded at parsing (behaviour wouldn't change for declarations
that fail to parse if we removed the property).

This should reduce the usage numbers on chromestatus.com for many
properties. For example while border-spacing is not specced as a
shorthand, it is implemented as a shorthand and we end up measuring
-webkit-border-horizontal-spacing whenever we parse border-spacing.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183636

[Timothy Loh, 2014-10-14 00:35:14]

timloh@chromium.org changed reviewers:
+ dstockwell@chromium.org, mikelawther@chromium.org

[Timothy Loh, 2014-10-14 00:35:14]

timloh@chromium.org changed reviewers:
+ dstockwell@chromium.org, mikelawther@chromium.org

[Timothy Loh, 2014-10-14 00:36:09]

timloh@chromium.org changed required reviewers:
+ dstockwell@chromium.org

[dstockwell, 2014-10-14 00:39:19]

lgtm,

Do you have the list of all affected properties? I think it would be worth
sending a quick PSA to blink-dev about this change.

[Timothy Loh, 2014-10-14 02:41:02]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2014-10-14 02:42:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642583006/1

[commit-bot: I haz the power, 2014-10-14 03:17:15]

Committed patchset #1 (id:1) as 183636