Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 642583003: Implement unprefixed EME APIs that match the latest draft (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, mkwst+moarreviews_chromium.org, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement unprefixed EME APIs that match the latest draft Update the API for WebContentDecryptionModule and WebContentDecryptionModuleSession in order to implement the latest EME API spec. BUG=224786 TEST=Adding to API, no code using it. All existing EME tests pass. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183627

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M Source/modules/encryptedmedia/MediaKeySession.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/exported/WebContentDecryptionModuleSession.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M public/platform/WebContentDecryptionModule.h View 2 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebContentDecryptionModuleSession.h View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jrummell
PTAL. This combines all the API changes needed so far.
6 years, 2 months ago (2014-10-09 00:20:34 UTC) #2
ddorwin
LGTM % comment. Thanks! https://codereview.chromium.org/642583003/diff/1/public/platform/WebContentDecryptionModuleSession.h File public/platform/WebContentDecryptionModuleSession.h (right): https://codereview.chromium.org/642583003/diff/1/public/platform/WebContentDecryptionModuleSession.h#newcode59 public/platform/WebContentDecryptionModuleSession.h:59: // Called when the expiration ...
6 years, 2 months ago (2014-10-09 00:25:25 UTC) #3
jrummell
+dglazkov@ for OWNERS review of Source/platform and public/platform. https://codereview.chromium.org/642583003/diff/1/public/platform/WebContentDecryptionModuleSession.h File public/platform/WebContentDecryptionModuleSession.h (right): https://codereview.chromium.org/642583003/diff/1/public/platform/WebContentDecryptionModuleSession.h#newcode59 public/platform/WebContentDecryptionModuleSession.h:59: // ...
6 years, 2 months ago (2014-10-09 00:30:08 UTC) #5
jrummell
dglazkov@: friendly ping.
6 years, 2 months ago (2014-10-13 20:05:22 UTC) #6
dglazkov
lgtm
6 years, 2 months ago (2014-10-13 20:06:01 UTC) #7
jrummell
Thanks for the reviews.
6 years, 2 months ago (2014-10-13 20:08:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642583003/20001
6 years, 2 months ago (2014-10-13 20:08:59 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/modules/encryptedmedia/MediaKeySession.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-13 20:09:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642583003/110001
6 years, 2 months ago (2014-10-13 20:54:07 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:27:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:110001) as 183627

Powered by Google App Engine
This is Rietveld 408576698