extensions/browser/guest_view/guest_view_manager.h - Issue 642573002: Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager.h

Issue 642573002: Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests_other0

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/guest_view_base.cc ('K') | « extensions/browser/guest_view/guest_view_base.cc ('k') | extensions/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_manager.h

diff --git a/extensions/browser/guest_view/guest_view_manager.h b/extensions/browser/guest_view/guest_view_manager.h

index e2bfce8bd55fee3e23e70b843d9484f797ab8a95..db13e7c98318fb9c46ec1d724a3d448f80ad6180 100644

--- a/extensions/browser/guest_view/guest_view_manager.h

+++ b/extensions/browser/guest_view/guest_view_manager.h

@@ -72,7 +72,7 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

content::WebContents* CreateGuestWithWebContentsParams(

const std::string& view_type,

const std::string& embedder_extension_id,

- int embedder_render_process_id,

+ content::WebContents* embedder_web_contents,

const content::WebContents::CreateParams& create_params);

content::SiteInstance* GetGuestSiteInstance(