Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: extensions/browser/guest_view/guest_view_manager.cc

Issue 642573002: Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests_other0
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_manager.cc
diff --git a/extensions/browser/guest_view/guest_view_manager.cc b/extensions/browser/guest_view/guest_view_manager.cc
index 77a46c6ab4b7095bb86e07b3df20b76d7478646b..0e64f30062eead53fca683d6ceae6c2b12375221 100644
--- a/extensions/browser/guest_view/guest_view_manager.cc
+++ b/extensions/browser/guest_view/guest_view_manager.cc
@@ -131,7 +131,7 @@ void GuestViewManager::CreateGuest(const std::string& view_type,
content::WebContents* GuestViewManager::CreateGuestWithWebContentsParams(
const std::string& view_type,
const std::string& embedder_extension_id,
- int embedder_render_process_id,
+ content::WebContents* embedder_web_contents,
const content::WebContents::CreateParams& create_params) {
int guest_instance_id = GetNextInstanceID();
GuestViewBase* guest =
@@ -142,8 +142,11 @@ content::WebContents* GuestViewManager::CreateGuestWithWebContentsParams(
guest_create_params.guest_delegate = guest;
content::WebContents* guest_web_contents =
WebContents::Create(guest_create_params);
+ int embedder_render_process_id =
+ embedder_web_contents->GetRenderProcessHost()->GetID();
guest->InitWithWebContents(embedder_extension_id,
embedder_render_process_id,
+ embedder_web_contents,
guest_web_contents);
return guest_web_contents;
}

Powered by Google App Engine
This is Rietveld 408576698