Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Side by Side Diff: extensions/browser/guest_view/guest_view_manager.h

Issue 642573002: Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests_other0
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_ 5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_
6 #define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_ 6 #define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 WebContentsCreatedCallback; 65 WebContentsCreatedCallback;
66 void CreateGuest(const std::string& view_type, 66 void CreateGuest(const std::string& view_type,
67 const std::string& embedder_extension_id, 67 const std::string& embedder_extension_id,
68 content::WebContents* embedder_web_contents, 68 content::WebContents* embedder_web_contents,
69 const base::DictionaryValue& create_params, 69 const base::DictionaryValue& create_params,
70 const WebContentsCreatedCallback& callback); 70 const WebContentsCreatedCallback& callback);
71 71
72 content::WebContents* CreateGuestWithWebContentsParams( 72 content::WebContents* CreateGuestWithWebContentsParams(
73 const std::string& view_type, 73 const std::string& view_type,
74 const std::string& embedder_extension_id, 74 const std::string& embedder_extension_id,
75 int embedder_render_process_id, 75 content::WebContents* embedder_web_contents,
76 const content::WebContents::CreateParams& create_params); 76 const content::WebContents::CreateParams& create_params);
77 77
78 content::SiteInstance* GetGuestSiteInstance( 78 content::SiteInstance* GetGuestSiteInstance(
79 const GURL& guest_site); 79 const GURL& guest_site);
80 80
81 // BrowserPluginGuestManager implementation. 81 // BrowserPluginGuestManager implementation.
82 virtual content::WebContents* GetGuestByInstanceID( 82 virtual content::WebContents* GetGuestByInstanceID(
83 content::WebContents* embedder_web_contents, 83 content::WebContents* embedder_web_contents,
84 int element_instance_id) override; 84 int element_instance_id) override;
85 virtual bool ForEachGuest(content::WebContents* embedder_web_contents, 85 virtual bool ForEachGuest(content::WebContents* embedder_web_contents,
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 std::set<int> removed_instance_ids_; 149 std::set<int> removed_instance_ids_;
150 150
151 content::BrowserContext* context_; 151 content::BrowserContext* context_;
152 152
153 DISALLOW_COPY_AND_ASSIGN(GuestViewManager); 153 DISALLOW_COPY_AND_ASSIGN(GuestViewManager);
154 }; 154 };
155 155
156 } // namespace extensions 156 } // namespace extensions
157 157
158 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_ 158 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_
OLDNEW
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.cc ('k') | extensions/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698