Issue 642493003: Revert of Use presence of a content key as non-scratch indicator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 642493003: Revert of Use presence of a content key as non-scratch indicator (Closed)

Created:
6 years, 2 months ago by bsalomon

Modified:
6 years, 2 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@pp

Project:
skia

Visibility:
Public.

Revert of Use presence of a content key as non-scratch indicator (patchset #5 id:80001 of https://codereview.chromium.org/639873002/) Reason for revert: breaking nanobench on ubuntu Original issue's description: > Use presence of a content key as non-scratch indicator > > BUG=skia:2889 > > Committed: https://skia.googlesource.com/skia/+/9eefe0851eeaa8ded05b4774ebcb38ed201d5dbf TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/0f9e8a720c583956ed6e291d018f40fa624bb40d

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -23 lines)			Patch
M	include/gpu/GrGpuResource.h	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrGpuResource.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	4 chunks	+10 lines, -5 lines	0 comments	Download
M	src/gpu/GrResourceCache2.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of Use presence of a content key as non-scratch indicator

6 years, 2 months ago (2014-10-08 18:21:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642493003/1

6 years, 2 months ago (2014-10-08 18:21:26 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-08 18:21:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 0f9e8a720c583956ed6e291d018f40fa624bb40d