Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 642483003: Use a valid WebMouseWheelEvent in stringification test (Closed)

Created:
6 years, 2 months ago by jdduke (slow)
Modified:
6 years, 2 months ago
CC:
bruening+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, glider+watch_chromium.org, jam, jdduke+watch_chromium.org, timurrrr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use a valid WebMouseWheelEvent in stringification test Use a proper WebMouseWheelEvent instance when validating the ToString behavior for events of type WebInputEvent::MouseWheel. BUG=422083 Committed: https://crrev.com/b2bdb2f4eee5b8c729335e8ef2e1832a6fde1e28 Cr-Commit-Position: refs/heads/master@{#299038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M content/common/input/web_input_event_traits_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jdduke (slow)
bruening@: PTAL, thanks.
6 years, 2 months ago (2014-10-09 23:05:56 UTC) #2
Derek Bruening
Suppression removal looks good. I don't know enough about WebMouseEvent vs WebMouseWheelEvent for that part.
6 years, 2 months ago (2014-10-09 23:24:12 UTC) #3
jdduke (slow)
+aelias@ for content/common/input
6 years, 2 months ago (2014-10-10 00:03:16 UTC) #5
aelias_OOO_until_Jul13
lgtm
6 years, 2 months ago (2014-10-10 00:22:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642483003/1
6 years, 2 months ago (2014-10-10 01:34:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 02:03:18 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:05:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2bdb2f4eee5b8c729335e8ef2e1832a6fde1e28
Cr-Commit-Position: refs/heads/master@{#299038}

Powered by Google App Engine
This is Rietveld 408576698