Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 642453004: [Telemetry] Change TracingBackend.Stop to return the trace data from last tracing run. (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change TracingBackend.Stop to return the trace data from last tracing run. The bug 421097 was caused by the refactoring to disable trace nesting call feature. Since trace-profiler makes the call to StartTracing earlier than measurement and makes the call top StopTracing after measurement has called StopTracing, it raises TracingNotRunningException(). This fixes the bug by modifying the behavior of StopTracing() slightly to return the trace data of the last run. Note that trace-profiler itself does not provide a good way to get useful trace data (the measurement uses tracing with different overhead level without knowing it). The long term fix should be moving all trace-based measurement to timeline_based_measurement. BUG=421097 Committed: https://crrev.com/48f92772739028b8bc5bca9302e0d51dd6fa9097 Cr-Commit-Position: refs/heads/master@{#298992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 4 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nednguyen
6 years, 2 months ago (2014-10-09 18:06:09 UTC) #2
ernstm
On 2014/10/09 18:06:09, nednguyen wrote: For smoothness with profiler=trace we would: profiler: StartTracing with default ...
6 years, 2 months ago (2014-10-09 21:58:50 UTC) #4
nednguyen
On 2014/10/09 21:58:50, ernstm wrote: > On 2014/10/09 18:06:09, nednguyen wrote: > > For smoothness ...
6 years, 2 months ago (2014-10-09 22:04:41 UTC) #5
ernstm
On 2014/10/09 22:04:41, nednguyen wrote: > On 2014/10/09 21:58:50, ernstm wrote: > > On 2014/10/09 ...
6 years, 2 months ago (2014-10-09 22:06:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642453004/1
6 years, 2 months ago (2014-10-09 22:09:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 22:20:59 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 22:22:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48f92772739028b8bc5bca9302e0d51dd6fa9097
Cr-Commit-Position: refs/heads/master@{#298992}

Powered by Google App Engine
This is Rietveld 408576698