Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: content/common/gpu/media/vt_video_decode_accelerator.h

Issue 642453003: Use NotifyError() to report errors in VTVideoDecodeAccelerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix space. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/media/vt_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/vt_video_decode_accelerator.h
diff --git a/content/common/gpu/media/vt_video_decode_accelerator.h b/content/common/gpu/media/vt_video_decode_accelerator.h
index 572f4d3324da0dd1e07efcabaa924380ec9b6466..ced436994f39d2db5d933052d6a850d9d43ca2d4 100644
--- a/content/common/gpu/media/vt_video_decode_accelerator.h
+++ b/content/common/gpu/media/vt_video_decode_accelerator.h
@@ -83,15 +83,17 @@ class VTVideoDecodeAccelerator
};
// Methods for interacting with VideoToolbox. Run on |decoder_thread_|.
- void ConfigureDecoder(
+ bool ConfigureDecoder(
const std::vector<const uint8_t*>& nalu_data_ptrs,
const std::vector<size_t>& nalu_data_sizes);
- void DecodeTask(const media::BitstreamBuffer);
+ void DecodeTask(const media::BitstreamBuffer&);
void FlushTask();
+ void DropBitstream(int32_t bitstream_id);
// Methods for interacting with |client_|. Run on |gpu_task_runner_|.
void OutputTask(DecodedFrame frame);
void SizeChangedTask(gfx::Size coded_size);
+ void NotifyError(Error error);
// Send decoded frames up to and including |up_to_bitstream_id|, and return
// the last sent |bitstream_id|.
@@ -122,6 +124,7 @@ class VTVideoDecodeAccelerator
//
CGLContextObj cgl_context_;
media::VideoDecodeAccelerator::Client* client_;
+ bool has_error_; // client_->NotifyError() called.
gfx::Size texture_size_;
std::queue<PendingAction> pending_actions_;
std::queue<int32_t> pending_bitstream_ids_;
« no previous file with comments | « no previous file | content/common/gpu/media/vt_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698