git cl format the first third of the net/base directory

net/base/directory_lister.h

Index: net/base/directory_lister.h
diff --git a/net/base/directory_lister.h b/net/base/directory_lister.h
index 5fbc9dc6fa15abd3c409aa4502327663dfa57e78..a7ad964220c64e51558443a968ed3ca1e345a93f 100644
--- a/net/base/directory_lister.h
+++ b/net/base/directory_lister.h
@@ -22,7 +22,7 @@ namespace net {
 // structs over to the main application thread.  The consumer of this class
 // is insulated from any of the multi-threading details.
 //
-class NET_EXPORT DirectoryLister  {
+class NET_EXPORT DirectoryLister {
  public:
   // Represents one file found.
   struct DirectoryListerData {
@@ -48,15 +48,9 @@ class NET_EXPORT DirectoryLister  {
   //   directories first in name order, then files by name order
   // FULL_PATH sorts by paths as strings, ignoring files v. directories
   // DATE sorts by last modified date
-  enum SortType {
-    NO_SORT,
-    DATE,
-    ALPHA_DIRS_FIRST,
-    FULL_PATH
-  };
+  enum SortType { NO_SORT, DATE, ALPHA_DIRS_FIRST, FULL_PATH };

[Ryan Sleevi, 2014/10/11 02:04:46]

So, here's an example where the original code was clearer.

However, the reason why git cl format did this is because the documentation was
listed in 47-50. If we move that documentation inline, above each enum value, it
should "do the right thing"

I don't think it's worth filing a git cl format bug on it, because I think it's
the right behaviour for the general case (which is designed for inline values)

[jkarlin, 2014/10/16 00:19:32]

Acknowledged.

[Peter Kasting, 2014/10/30 20:20:59]

Is there a case where enums are really better with all values collapsed
together?  I feel like for "enum X { ... }", the contents of the braces should
always be on their own lines, and would suggest filing a clang-format bug about
it.

[jkarlin, 2014/11/11 19:01:43]

I think this comes down to opinion, I personally like it shorter. 

 
-  DirectoryLister(const base::FilePath& dir,
-                  DirectoryListerDelegate* delegate);
+  DirectoryLister(const base::FilePath& dir, DirectoryListerDelegate* delegate);
 
   DirectoryLister(const base::FilePath& dir,
                   bool recursive,