net/base/net_info_source_list.h - Issue 642403002: git cl format the first third of the net/base directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/net_info_source_list.h

Issue 642403002: git cl format the first third of the net/base directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/base/keygen_handler_mac.cc ('K') | « net/base/net_errors_win.cc ('k') | net/base/net_log_event_type_list.h » ('j') | net/base/net_log_util.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file intentionally does not have header guards, it's included	5 // This file intentionally does not have header guards, it's included

6 // inside a macro to generate enum values.	6 // inside a macro to generate enum values.

7	7

8 // Flags used to request different types of information about the current state	8 // Flags used to request different types of information about the current state

9 // of a URLRequestContext.	9 // of a URLRequestContext.

10 //	10 //

11 // The strings don't match the enums for historical reasons.	11 // The strings don't match the enums for historical reasons.

12	12

13 NET_INFO_SOURCE(PROXY_SETTINGS, "proxySettings", 1 << 0)	13 NET_INFO_SOURCE(PROXY_SETTINGS, "proxySettings", 1 << 0)

14 NET_INFO_SOURCE(BAD_PROXIES, "badProxies", 1 << 1)	14 NET_INFO_SOURCE(BAD_PROXIES, "badProxies", 1 << 1)

15 NET_INFO_SOURCE(HOST_RESOLVER, "hostResolverInfo", 1 << 2)	15 NET_INFO_SOURCE(HOST_RESOLVER, "hostResolverInfo", 1 << 2)

16 NET_INFO_SOURCE(SOCKET_POOL, "socketPoolInfo", 1 << 3)	16 NET_INFO_SOURCE(SOCKET_POOL, "socketPoolInfo", 1 << 3)

17 NET_INFO_SOURCE(QUIC, "quicInfo", 1 << 4)	17 NET_INFO_SOURCE(QUIC, "quicInfo", 1 << 4)

18 NET_INFO_SOURCE(SPDY_SESSIONS, "spdySessionInfo", 1 << 5)	18 NET_INFO_SOURCE(SPDY_SESSIONS, "spdySessionInfo", 1 << 5)

19 NET_INFO_SOURCE(SPDY_STATUS, "spdyStatus", 1 << 6)	19 NET_INFO_SOURCE(SPDY_STATUS, "spdyStatus", 1 << 6)

20 NET_INFO_SOURCE(SPDY_ALT_PROTO_MAPPINGS, "spdyAlternateProtocolMappings",	20 NET_INFO_SOURCE(SPDY_ALT_PROTO_MAPPINGS,

21 1 << 7)	21 "spdyAlternateProtocolMappings",

22 NET_INFO_SOURCE(HTTP_CACHE, "httpCacheInfo", 1 << 8)	22 1 << 7)

	23 NET_INFO_SOURCE(HTTP_CACHE, "httpCacheInfo", 1 << 8)
	mmenke 2014/12/02 19:22:29 Not great...This is the kind of a place a no forma Not great...This is the kind of a place a no format header may be useful. Ryan Sleevi 2014/12/02 19:38:45 The original code was not style guide compliant. Show quoted text On 2014/12/02 19:22:29, mmenke wrote: > Not great...This is the kind of a place a no format header may be useful. The original code was not style guide compliant. mmenke 2014/12/02 19:44:50 Does the style guide say anything about formatting Show quoted text On 2014/12/02 19:38:45, Ryan Sleevi wrote: > On 2014/12/02 19:22:29, mmenke wrote: > > Not great...This is the kind of a place a no format header may be useful. > > The original code was not style guide compliant. Does the style guide say anything about formatting macro usage?
OLD	NEW