Add the ability to load multiple apps into app_shell.

extensions/shell/browser/shell_extension_system.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/browser/shell_extension_system.h"
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 19 matching lines @@
 
 namespace extensions {
 
 ShellExtensionSystem::ShellExtensionSystem(BrowserContext* browser_context)
     : browser_context_(browser_context) {
 }
 
 ShellExtensionSystem::~ShellExtensionSystem() {
 }
 
-bool ShellExtensionSystem::LoadApp(const base::FilePath& app_dir) {
+const Extension* ShellExtensionSystem::LoadApp(const base::FilePath& app_dir) {
   // app_shell only supports unpacked extensions.
   // NOTE: If you add packed extension support consider removing the flag
   // FOLLOW_SYMLINKS_ANYWHERE below. Packed extensions should not have symlinks.
   CHECK(base::DirectoryExists(app_dir)) << app_dir.AsUTF8Unsafe();
   int load_flags = Extension::FOLLOW_SYMLINKS_ANYWHERE;
   std::string load_error;
-  extension_ = file_util::LoadExtension(
+  scoped_refptr<Extension> extension_refptr = file_util::LoadExtension(

[James Cook, 2014/10/23 21:29:52]

nit: I find it awkward to have both extension_refptr and extension. Consider
just using scoped_refptr<Extension> extension and using extension.get().

[lfg, 2014/10/23 22:04:05]

Done.

       app_dir, Manifest::COMMAND_LINE, load_flags, &load_error);
-  if (!extension_.get()) {
+  Extension* extension = extension_refptr.get();
+  if (!extension) {
     LOG(ERROR) << "Loading extension at " << app_dir.value()
                << " failed with: " << load_error;
-    return false;
+    return nullptr;
   }
-  app_id_ = extension_->id();
 
   // TODO(jamescook): We may want to do some of these things here:
   // * Create a PermissionsUpdater.
   // * Call PermissionsUpdater::GrantActivePermissions().
   // * Call ExtensionService::SatisfyImports().
   // * Call ExtensionPrefs::OnExtensionInstalled().
   // * Send NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATED.
 
-  ExtensionRegistry::Get(browser_context_)->AddEnabled(extension_);
+  extensions_.Insert(extension_refptr);

[James Cook, 2014/10/23 21:29:53]

Do you need extensions_ at all? Can you just get the list out of
ExtensionRegistry::Get(context)->enabled_extensions()?

[lfg, 2014/10/23 22:04:05]

Indeed, that is not necessary. Removed.

 
-  RegisterExtensionWithRequestContexts(extension_.get());
+  ExtensionRegistry::Get(browser_context_)->AddEnabled(extension_refptr);
+
+  RegisterExtensionWithRequestContexts(extension);
 
   content::NotificationService::current()->Notify(
       extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
       content::Source<BrowserContext>(browser_context_),
-      content::Details<const Extension>(extension_.get()));
+      content::Details<const Extension>(extension));
 
+  return extension;
+}
+
+bool ShellExtensionSystem::Init() {
   // Inform the rest of the extensions system to start.
   ready_.Signal();
   content::NotificationService::current()->Notify(
       extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED,
       content::Source<BrowserContext>(browser_context_),
       content::NotificationService::NoDetails());
   return true;
 }
 
-void ShellExtensionSystem::LaunchApp() {
+void ShellExtensionSystem::LaunchApp(const ExtensionId& extension_id) {
   // Send the onLaunched event.
-  DCHECK(extension_.get());
-  AppRuntimeEventRouter::DispatchOnLaunchedEvent(browser_context_,
-                                                 extension_.get());
+  DCHECK(extensions_.Contains(extension_id));
+  const Extension* extension = extensions_.GetByID(extension_id);
+  AppRuntimeEventRouter::DispatchOnLaunchedEvent(browser_context_, extension);
 }
 
 void ShellExtensionSystem::Shutdown() {
 }
 
 void ShellExtensionSystem::InitForRegularProfile(bool extensions_enabled) {
   runtime_data_.reset(
       new RuntimeData(ExtensionRegistry::Get(browser_context_)));
   lazy_background_task_queue_.reset(
       new LazyBackgroundTaskQueue(browser_context_));
@@ skipping 95 matching lines @@
   return make_scoped_ptr(new ExtensionSet());
 }
 
 DeclarativeUserScriptMaster*
 ShellExtensionSystem::GetDeclarativeUserScriptMasterByExtension(
     const ExtensionId& extension_id) {
   return NULL;
 }
 
 }  // namespace extensions