Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 642383002: Only include NotImplemented.h when it is actually used (when notImplemented() is called). (Closed)

Created:
6 years, 2 months ago by lgombos
Modified:
6 years, 2 months ago
Reviewers:
Mike West, eseidel
CC:
blink-reviews, tzik, fs, eric.carlson_apple.com, kinuko+worker_chromium.org, aandrey+blink_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, pdr+graphicswatchlist_chromium.org, blink-reviews-html_chromium.org, danakj, dglazkov+blink, Rik, nessy, jbroman, nhiroki, feature-media-reviews_chromium.org, krit, timvolodine, vcarbune.chromium, michaeln, serviceworker-reviews, gasubic, mkwst+moarreviews_chromium.org, falken, kinuko+serviceworker, horo+watch_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Only include NotImplemented.h when it is actually used (when notImplemented() is called). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Request.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
lgombos
Trivial cleanup - makes it easier to find actually NotImplemented bits.
6 years, 2 months ago (2014-10-10 18:26:29 UTC) #2
Mike West
lgtm, thanks.
6 years, 2 months ago (2014-10-10 18:49:25 UTC) #4
philipj_slow
Typo in description: NotIMplemented.h
6 years, 2 months ago (2014-10-10 19:41:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642383002/1
6 years, 2 months ago (2014-10-10 20:16:13 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 23:15:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183566

Powered by Google App Engine
This is Rietveld 408576698