Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 642363002: Fix bad log message in AndroidPlatformBackend. (Closed)

Created:
6 years, 2 months ago by vmiura
Modified:
6 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bad log message in AndroidPlatformBackend. BUG=419901 Committed: https://crrev.com/736a62993161df9af63f2f183b9a9ea3d5dd14a6 Cr-Commit-Position: refs/heads/master@{#299152}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vmiura
nednguyen@google.com: Please review this change.
6 years, 2 months ago (2014-10-10 17:09:31 UTC) #2
nednguyen
https://codereview.chromium.org/642363002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/642363002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py#newcode72 tools/telemetry/telemetry/core/platform/android_platform_backend.py:72: logging.warning('CPU governor will not be set!') Maybe move this ...
6 years, 2 months ago (2014-10-10 17:38:26 UTC) #3
nednguyen
lgtm
6 years, 2 months ago (2014-10-10 17:38:32 UTC) #4
vmiura
https://codereview.chromium.org/642363002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/642363002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py#newcode72 tools/telemetry/telemetry/core/platform/android_platform_backend.py:72: logging.warning('CPU governor will not be set!') On 2014/10/10 17:38:26, ...
6 years, 2 months ago (2014-10-10 17:44:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642363002/90001
6 years, 2 months ago (2014-10-10 17:45:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:90001)
6 years, 2 months ago (2014-10-10 18:55:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:56:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/736a62993161df9af63f2f183b9a9ea3d5dd14a6
Cr-Commit-Position: refs/heads/master@{#299152}

Powered by Google App Engine
This is Rietveld 408576698