Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 642353003: Sets uncompiled_source web_request_internal for schema on GN builds. (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Sets uncompiled_source web_request_internal for schema on GN builds. BUG=None R=rockot@chromium.org TEST=None Committed: https://crrev.com/29979e7d5e0c27acd2cf8a88de5c45a4a4d53d35 Cr-Commit-Position: refs/heads/master@{#299183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M extensions/common/api/schemas.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Jun Mukai
6 years, 2 months ago (2014-10-10 20:31:24 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-10 20:33:11 UTC) #2
Ken Rockot(use gerrit already)
Actually, nit: Could you please make this change in chrome/common/extensions/api/BUILD.gn too while you're here?
6 years, 2 months ago (2014-10-10 20:34:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642353003/1
6 years, 2 months ago (2014-10-10 20:35:22 UTC) #5
Jun Mukai
On 2014/10/10 20:34:25, Ken Rockot wrote: > Actually, nit: Could you please make this change ...
6 years, 2 months ago (2014-10-10 20:38:04 UTC) #6
Ken Rockot(use gerrit already)
Woops, read the wrong file <facepalm/> Thanks. On Fri, Oct 10, 2014 at 1:38 PM, ...
6 years, 2 months ago (2014-10-10 20:38:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 20:58:22 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 20:59:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29979e7d5e0c27acd2cf8a88de5c45a4a4d53d35
Cr-Commit-Position: refs/heads/master@{#299183}

Powered by Google App Engine
This is Rietveld 408576698