Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/extensions/api/file_system/entry_watcher_service.h

Issue 642343004: [ew] Simplify the entry watcher logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NULL -> nullptr Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/file_system/entry_watcher_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/file_system/entry_watcher_service.h
diff --git a/chrome/browser/extensions/api/file_system/entry_watcher_service.h b/chrome/browser/extensions/api/file_system/entry_watcher_service.h
deleted file mode 100644
index 5b3ddd44210833c928774418587f93dd8aab0f08..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/file_system/entry_watcher_service.h
+++ /dev/null
@@ -1,128 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_ENTRY_WATCHER_SERVICE_H_
-#define CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_ENTRY_WATCHER_SERVICE_H_
-
-#include <map>
-#include <string>
-#include <vector>
-
-#include "base/memory/singleton.h"
-#include "base/memory/weak_ptr.h"
-#include "base/scoped_observer.h"
-#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
-#include "components/keyed_service/core/keyed_service.h"
-#include "storage/browser/fileapi/file_system_url.h"
-#include "storage/browser/fileapi/watcher_manager.h"
-
-namespace content {
-class BrowserContext;
-} // namespace content
-
-namespace storage {
-class FileSystemContext;
-} // namespace storage
-
-namespace extensions {
-struct Event;
-class EventRouter;
-
-// Watches entries (files and directories) for changes. Created per profile.
-// TODO(mtomasz): Add support for watching files.
-class EntryWatcherService : public KeyedService,
- public storage::WatcherManager::Observer {
- public:
- typedef base::Callback<
- void(const std::string& extension_id, scoped_ptr<Event> event)>
- DispatchEventImplCallback;
-
- typedef base::Callback<storage::FileSystemContext*(
- const std::string& extension_id,
- content::BrowserContext* context)> GetFileSystemContextImplCallback;
-
- explicit EntryWatcherService(content::BrowserContext* context);
- ~EntryWatcherService() override;
-
- // Watches a directory. Only one watcher can be set per the same |url| and
- // |extension_id|.
- void WatchDirectory(const std::string& extension_id,
- const storage::FileSystemURL& url,
- bool recursive,
- const storage::WatcherManager::StatusCallback& callback);
-
- // Unwatches an entry (file or directory).
- void UnwatchEntry(const std::string& extension_id,
- const storage::FileSystemURL& url,
- const storage::WatcherManager::StatusCallback& callback);
-
- std::vector<storage::FileSystemURL> GetWatchedEntries(
- const std::string& extension_id);
-
- // storage::WatcherManager::Observer overrides.
- void OnEntryChanged(const storage::FileSystemURL& url) override;
- void OnEntryRemoved(const storage::FileSystemURL& url) override;
-
- // Sets a custom dispatcher for tests in order to be able to verify dispatched
- // events.
- void SetDispatchEventImplForTesting(
- const DispatchEventImplCallback& callback);
-
- // Sets a custom context getter for tests in order to inject a testing
- // file system context implementation.
- void SetGetFileSystemContextImplForTesting(
- const GetFileSystemContextImplCallback& callback);
-
- private:
- // Holds information about an active entry watcher.
- struct EntryWatcher {
- EntryWatcher();
- EntryWatcher(const storage::FileSystemURL& url,
- bool directory,
- bool recursive);
- ~EntryWatcher();
-
- storage::FileSystemURL url;
- bool directory;
- bool recursive;
- };
-
- // Map from a file system url to a map from an extension id to an entry
- // watcher descriptor.
- typedef std::map<storage::FileSystemURL,
- std::map<std::string, EntryWatcher>,
- storage::FileSystemURL::Comparator> WatcherMap;
-
- // Called when adding a directory watcher is completed with either a success
- // or an error.
- void OnWatchDirectoryCompleted(
- storage::WatcherManager* watcher_manager,
- const std::string& extension_id,
- const storage::FileSystemURL& url,
- bool recursive,
- const storage::WatcherManager::StatusCallback& callback,
- base::File::Error result);
-
- // Called when removing a watcher is completed with either a success or an
- // error.
- void OnUnwatchEntryCompleted(
- const std::string& extension_id,
- const storage::FileSystemURL& url,
- const storage::WatcherManager::StatusCallback& callback,
- base::File::Error result);
-
- content::BrowserContext* context_;
- WatcherMap watchers_;
- DispatchEventImplCallback dispatch_event_impl_;
- GetFileSystemContextImplCallback get_file_system_context_impl_;
- ScopedObserver<storage::WatcherManager, storage::WatcherManager::Observer>
- observing_;
- base::WeakPtrFactory<EntryWatcherService> weak_ptr_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(EntryWatcherService);
-};
-
-} // namespace extensions
-
-#endif // CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_ENTRY_WATCHER_SERVICE_H_
« no previous file with comments | « no previous file | chrome/browser/extensions/api/file_system/entry_watcher_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698