Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 642333002: [Ozone-DRI] Fix panel fitting lookup (Closed)

Created:
6 years, 2 months ago by dnicoara
Modified:
6 years, 2 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRI] Fix panel fitting lookup BUG=none NOTRY=true Committed: https://crrev.com/e7157b03f238a503f2fff9c2d68b9dff04da40dd Cr-Commit-Position: refs/heads/master@{#299128}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ui/ozone/platform/dri/display_snapshot_dri.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dnicoara
PTAL
6 years, 2 months ago (2014-10-10 14:38:54 UTC) #2
alexst (slow to review)
lgtm https://codereview.chromium.org/642333002/diff/1/ui/ozone/platform/dri/display_snapshot_dri.cc File ui/ozone/platform/dri/display_snapshot_dri.cc (right): https://codereview.chromium.org/642333002/diff/1/ui/ozone/platform/dri/display_snapshot_dri.cc#newcode50 ui/ozone/platform/dri/display_snapshot_dri.cc:50: if (connector->props[i] != property->prop_id) I found my mind ...
6 years, 2 months ago (2014-10-10 15:00:09 UTC) #3
dnicoara
https://codereview.chromium.org/642333002/diff/1/ui/ozone/platform/dri/display_snapshot_dri.cc File ui/ozone/platform/dri/display_snapshot_dri.cc (right): https://codereview.chromium.org/642333002/diff/1/ui/ozone/platform/dri/display_snapshot_dri.cc#newcode50 ui/ozone/platform/dri/display_snapshot_dri.cc:50: if (connector->props[i] != property->prop_id) On 2014/10/10 15:00:08, alexst wrote: ...
6 years, 2 months ago (2014-10-10 15:07:14 UTC) #4
alexst (slow to review)
still lgtm, thank you.
6 years, 2 months ago (2014-10-10 15:28:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642333002/80001
6 years, 2 months ago (2014-10-10 16:48:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 2 months ago (2014-10-10 16:49:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 16:50:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7157b03f238a503f2fff9c2d68b9dff04da40dd
Cr-Commit-Position: refs/heads/master@{#299128}

Powered by Google App Engine
This is Rietveld 408576698