Move style building for grid-auto-flow to StyleBuilderConverter.

Move style building for grid-auto-flow to StyleBuilderConverter.

There doesn't appear to be a reason for this property to have
custom behavior. It's better to use a converter and call that
from the generated function.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183595

[andersr, 2014-10-10 12:06:39]

andersr@opera.com changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2014-10-10 14:38:45]

lgtm

https://codereview.chromium.org/642303002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleBuilderConverter.cpp (right):

https://codereview.chromium.org/642303002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderConverter.cpp:348: return
RenderStyle::initialGridAutoFlow();
Looks like the parser always puts at least one value in the list so this is
unreachable

https://codereview.chromium.org/642303002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderConverter.cpp:350: CSSPrimitiveValue*
second = list->length() == 2 ? toCSSPrimitiveValue(list->item(1)) : nullptr;
All the logic here should probably get moved to the parser so we'd just have a
Pair([Row|Column], [Dense|Stack|Sparse]) here, but that's a change for another
day.

[Timothy Loh, 2014-10-10 16:12:20]

https://codereview.chromium.org/642303002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleBuilderConverter.cpp (right):

https://codereview.chromium.org/642303002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderConverter.cpp:350: CSSPrimitiveValue*
second = list->length() == 2 ? toCSSPrimitiveValue(list->item(1)) : nullptr;
On 2014/10/10 14:38:45, Timothy Loh wrote:
> All the logic here should probably get moved to the parser so we'd just have a
> Pair([Row|Column], [Dense|Stack|Sparse]) here, but that's a change for another
> day.

Err probably we'd have either a single value for the direction-only case or a
pair otherwise.

[andersr, 2014-10-13 08:36:14]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 08:36:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642303002/110001

[commit-bot: I haz the power, 2014-10-13 09:39:55]

Committed patchset #2 (id:110001) as 183595