Use C++11 range-based loop in core/frame

Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 116 matching lines @@
     // frame object keep weak references to the frame; those will be
     // automatically cleared by the garbage collector. Hence, explicit
     // frameDestroyed() notifications aren't needed.
 #else
     // FIXME: follow Oilpan and clear the FrameView and FrameLoader
     // during FrameOwner detachment instead, see LocalFrame::disconnectOwnerElement().
     setView(nullptr);
     m_loader.clear();
     setDOMWindow(nullptr);
 
-    HashSet<RawPtr<FrameDestructionObserver> >::iterator stop = m_destructionObservers.end();
-    for (HashSet<RawPtr<FrameDestructionObserver> >::iterator it = m_destructionObservers.begin(); it != stop; ++it)
-        (*it)->frameDestroyed();
+    for (const auto& frameDestructionObserver : m_destructionObservers)
+        frameDestructionObserver->frameDestroyed();
 #endif
 }
 
 void LocalFrame::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_destructionObservers);
     visitor->trace(m_loader);
     visitor->trace(m_navigationScheduler);
     visitor->trace(m_view);
     visitor->trace(m_pagePopupOwner);
     visitor->trace(m_script);
     visitor->trace(m_editor);
     visitor->trace(m_spellChecker);
     visitor->trace(m_selection);
     visitor->trace(m_eventHandler);
     visitor->trace(m_console);
     visitor->trace(m_inputMethodController);
     visitor->registerWeakMembers<LocalFrame, &LocalFrame::clearWeakMembers>(this);
     HeapSupplementable<LocalFrame>::trace(visitor);
 #endif
     Frame::trace(visitor);
 }
 
 #if ENABLE(OILPAN)
 void LocalFrame::clearWeakMembers(Visitor* visitor)
 {
     Vector<HTMLPlugInElement*> deadPlugins;
-    for (HashSet<HTMLPlugInElement*>::const_iterator it = m_pluginElements.begin(); it != m_pluginElements.end(); ++it) {
-        if (!visitor->isAlive(*it)) {
-            (*it)->shouldDisposePlugin();
-            deadPlugins.append(*it);
+    for (const auto& pluginElement : m_pluginElements) {
+        if (!visitor->isAlive(pluginElement)) {
+            pluginElement->shouldDisposePlugin();
+            deadPlugins.append(pluginElement);
         }
     }
     for (unsigned i = 0; i < deadPlugins.size(); ++i)
         m_pluginElements.remove(deadPlugins[i]);
 }
 #endif
 
 void LocalFrame::navigate(Document& originDocument, const KURL& url, bool lockBackForwardList)
 {
     m_navigationScheduler.scheduleLocationChange(&originDocument, url.string(), lockBackForwardList);
@@ skipping 162 matching lines @@
 
 void LocalFrame::willDetachFrameHost()
 {
     // We should never be detatching the page during a Layout.
     RELEASE_ASSERT(!m_view || !m_view->isInPerformLayout());
 
     Frame* parent = tree().parent();
     if (parent && parent->isLocalFrame())
         toLocalFrame(parent)->loader().checkLoadComplete();
 
-    WillBeHeapHashSet<RawPtrWillBeWeakMember<FrameDestructionObserver> >::iterator stop = m_destructionObservers.end();
-    for (WillBeHeapHashSet<RawPtrWillBeWeakMember<FrameDestructionObserver> >::iterator it = m_destructionObservers.begin(); it != stop; ++it)
-        (*it)->willDetachFrameHost();
+    for (const auto& frameDestructionObserver : m_destructionObservers)
+        frameDestructionObserver->willDetachFrameHost();
 
     // FIXME: Page should take care of updating focus/scrolling instead of Frame.
     // FIXME: It's unclear as to why this is called more than once, but it is,
     // so page() could be null.
     if (page() && page()->focusController().focusedFrame() == this)
         page()->focusController().setFocusedFrame(nullptr);
     script().clearScriptObjects();
 
     if (page() && page()->scrollingCoordinator() && m_view)
         page()->scrollingCoordinator()->willDestroyScrollableArea(m_view.get());
@@ skipping 370 matching lines @@
 }
 
 void LocalFrame::disconnectOwnerElement()
 {
     if (owner()) {
         if (Document* document = this->document())
             document->topDocument().clearAXObjectCache();
 #if ENABLE(OILPAN)
         // First give the plugin elements holding persisted,
         // renderer-less plugins the opportunity to dispose of them.
-        for (HashSet<HTMLPlugInElement*>::const_iterator it = m_pluginElements.begin(); it != m_pluginElements.end(); ++it)
-            (*it)->disconnectContentFrame();
+        for (const auto& pluginElement : m_pluginElements)
+            pluginElement->disconnectContentFrame();
         m_pluginElements.clear();
 
         // Clear the FrameView and FrameLoader right here rather than
         // during finalization. Too late to access various heap objects
         // at that stage.
         setView(nullptr);
         loader().clear();
 #endif
     }
     Frame::disconnectOwnerElement();
@@ skipping 20 matching lines @@
 }
 
 void LocalFrame::unregisterPluginElement(HTMLPlugInElement* plugin)
 {
     ASSERT(m_pluginElements.contains(plugin));
     m_pluginElements.remove(plugin);
 }
 #endif
 
 } // namespace blink