content/browser/devtools/protocol/page_handler.h - Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix that will be needed for browser protocol Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_handler_generator.py ('k') | content/browser/devtools/protocol/page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/page_handler.h

diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h

index fe01ece07941b0eee5a3b3b5413ec403d28d34ab..c6ed1b1973d0ff356585e336232d3ff6242d128f 100644

--- a/content/browser/devtools/protocol/page_handler.h

+++ b/content/browser/devtools/protocol/page_handler.h

@@ -47,8 +47,9 @@ class PageHandler {

Response Navigate(const std::string& url, FrameId* frame_id);

+ using NavigationEntries = std::vector<scoped_refptr<NavigationEntry>>;

Response GetNavigationHistory(int* current_index,

- std::vector<NavigationEntry>* entries);

+ NavigationEntries* entries);

Response NavigateToHistoryEntry(int entry_id);

@@ -101,7 +102,7 @@ class PageHandler {

void QueryUsageAndQuotaCompleted(

scoped_refptr<DevToolsProtocol::Command> command,

- scoped_ptr<QueryUsageAndQuotaResponse> response);

+ scoped_refptr<QueryUsageAndQuotaResponse> response);

bool enabled_;

bool touch_emulation_enabled_;