content/browser/devtools/protocol/devtools_protocol_client.cc - Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.cc

Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix that will be needed for browser protocol Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_client.h ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_client.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_client.cc b/content/browser/devtools/protocol/devtools_protocol_client.cc

index a34189e0efc17f98725ceca4d6796a80226c3dde..e959da9613620549f458d4b7bc63cf68a148e4a9 100644

--- a/content/browser/devtools/protocol/devtools_protocol_client.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_client.cc

@@ -14,10 +14,11 @@ DevToolsProtocolClient::DevToolsProtocolClient(

DevToolsProtocolClient::~DevToolsProtocolClient() {

}

-void DevToolsProtocolClient::SendNotification(const std::string& method,

- base::DictionaryValue* params) {

+void DevToolsProtocolClient::SendNotification(

+ const std::string& method,

+ scoped_ptr<base::DictionaryValue> params) {

scoped_refptr<DevToolsProtocol::Notification> notification =

- new DevToolsProtocol::Notification(method, params);

+ new DevToolsProtocol::Notification(method, params.release());

SendRawMessage(notification->Serialize());

}