content/browser/devtools/protocol/devtools_protocol_client.h - Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.h

Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed indentation in generated code Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/devtools/protocol/devtools_protocol_client.cc » ('j') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_client.h

diff --git a/content/browser/devtools/protocol/devtools_protocol_client.h b/content/browser/devtools/protocol/devtools_protocol_client.h

index 620a7c14995d8265fdc4dc8492914d1241520c7c..19f8fdf93603a0f80dd16dd51d5865402aec9bd5 100644

--- a/content/browser/devtools/protocol/devtools_protocol_client.h

+++ b/content/browser/devtools/protocol/devtools_protocol_client.h

@@ -60,7 +60,7 @@ class DevToolsProtocolClient {

virtual ~DevToolsProtocolClient();

void SendNotification(const std::string& method,

- base::DictionaryValue* params);

+ scoped_ptr<base::DictionaryValue> params);

void SendAsyncResponse(scoped_refptr<DevToolsProtocol::Response> response);