Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8905)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.cc

Issue 642263004: [DevTools] Make generated protocol structs wrappers around DictionaryValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_client.h ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_client.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_client.cc b/content/browser/devtools/protocol/devtools_protocol_client.cc
index a0d9547d1bc675750f337a96cac055b64245b99e..57145613c74828c160fa3d62d3936e1b64412cf8 100644
--- a/content/browser/devtools/protocol/devtools_protocol_client.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_client.cc
@@ -16,9 +16,10 @@ DevToolsProtocolClient::DevToolsProtocolClient(
DevToolsProtocolClient::~DevToolsProtocolClient() {
}
-void DevToolsProtocolClient::SendNotification(const std::string& method,
- base::DictionaryValue* params) {
- event_callback_.Run(method, params);
+void DevToolsProtocolClient::SendNotification(
+ const std::string& method,
+ scoped_ptr<base::DictionaryValue> params) {
+ event_callback_.Run(method, params.release());
}
void DevToolsProtocolClient::SendAsyncResponse(
« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_client.h ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698