Don't run deps2git if the repo doesn't have a .DEPS.git.

Don't run deps2git if the repo doesn't have a .DEPS.git.

Also, get rid of obsolete FLAG_DAY global variable.

And fix the tests.

R=hinoka@chromium.org,machenbach@chromium.org,mmoss@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292406

[Michael Achenbach, 2014-10-10 07:31:39]

lgtm

https://codereview.chromium.org/642253002/diff/1/tests/bot_update_test.py
File tests/bot_update_test.py (right):

https://codereview.chromium.org/642253002/diff/1/tests/bot_update_test.py#new...
tests/bot_update_test.py:515: 'properties': {'got_revision':
self.template_dict['top_revision_0']},
Can't say much about this...

[Michael Moss, 2014-10-10 15:36:55]

lgtm

[szager1, 2014-10-10 16:16:19]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-10-10 16:16:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642253002/1

[commit-bot: I haz the power, 2014-10-10 16:19:07]

Committed patchset #1 (id:1) as 292406

[zty, 2014-10-10 18:11:27]

zty@chromium.org changed reviewers:
+ zty@chromium.org

[zty, 2014-10-10 18:11:28]

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:285: GIT_MASTERS += internal_data.get('GIT_MASTERS',
[])
Delete this ?

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:549: if not buildspec:
this if block should be deleted if FLAG_DAY is True

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:1556: use_svn_rev = master not in GIT_MASTERS
This should be deleted if FLAG_DAY is True. use_svn_rev should always be False.

[szager1, 2014-10-10 18:18:10]

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:549: if not buildspec:
On 2014/10/10 18:11:28, zty wrote:
> this if block should be deleted if FLAG_DAY is True

No, it's still needed.  We still sometimes do builds from buildspecs instead of
DEPS.

https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:1556: use_svn_rev = master not in GIT_MASTERS
On 2014/10/10 18:11:28, zty wrote:
> This should be deleted if FLAG_DAY is True. use_svn_rev should always be
False.

Hmm, I have to think about that.  There may still be non-chromium cases that
need this.  hinoka would know better than I.

[agable, 2014-10-13 09:30:01]

On 2014/10/10 18:18:10, szager1 wrote:
> https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py
> File scripts/slave/bot_update.py (right):
> 
>
https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
> scripts/slave/bot_update.py:549: if not buildspec:
> On 2014/10/10 18:11:28, zty wrote:
> > this if block should be deleted if FLAG_DAY is True
> 
> No, it's still needed.  We still sometimes do builds from buildspecs instead
of
> DEPS.
> 
>
https://codereview.chromium.org/642253002/diff/1/scripts/slave/bot_update.py#...
> scripts/slave/bot_update.py:1556: use_svn_rev = master not in GIT_MASTERS
> On 2014/10/10 18:11:28, zty wrote:
> > This should be deleted if FLAG_DAY is True. use_svn_rev should always be
> False.
> 
> Hmm, I have to think about that.  There may still be non-chromium cases that
> need this.  hinoka would know better than I.

This CL has claimed its first victim: the webrtc.DEPS directory doesn't have a
.DEPS.git file committed to it, so we are no longer generating a .DEPS.git file
since we think we don't have to.

Rather than reverting this, I'm working to convert their DEPS file to git.

Follow along here: https://code.google.com/p/chromium/issues/detail?id=422864