Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 642243004: webtry: Simplify template construction. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org, humper
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

webtry: Simplify template construction. text/template and html/template both have a helper function called "Must" that according to the docs in http://golang.org/pkg/text/template/#Must and http://golang.org/pkg/html/template/#Must, wraps a call to a function returning (*Template, error) and panics if the error is non-nil. So we don't need to that ourselves. Which is a good thing and makes code cleaner. BUG=None TEST=None R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/585a5fc243e290ad9055ae1439a5e505d1ce7368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -28 lines) Patch
M experimental/webtry/webtry.go View 1 chunk +10 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
ptal.
6 years, 2 months ago (2014-10-13 21:10:59 UTC) #1
tfarina
Reversing. +joe, could you review this to me?
6 years, 2 months ago (2014-10-14 15:47:12 UTC) #3
jcgregorio
On 2014/10/14 15:47:12, tfarina wrote: > Reversing. > > +joe, could you review this to ...
6 years, 2 months ago (2014-10-14 16:29:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642243004/1
6 years, 2 months ago (2014-10-14 16:32:58 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 16:39:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 585a5fc243e290ad9055ae1439a5e505d1ce7368

Powered by Google App Engine
This is Rietveld 408576698