Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 642233003: Simplify language feature management. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
rossberg, adamk
CC:
adamk, arv (Not doing code reviews), v8-dev
Project:
v8
Visibility:
Public.

Description

Simplify language feature management. R=rossberg@chromium.org BUG=v8:3640 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24743

Patch Set 1 #

Patch Set 2 : Work in progress #

Patch Set 3 : Native function + global #

Patch Set 4 : Bootstrapper changes done, need to fake flag #

Patch Set 5 : Read-only flags for shipping features #

Patch Set 6 : Style nit #

Patch Set 7 : Rebased #

Patch Set 8 : NOT FOR LANDING - example of shipping a feature #

Total comments: 4

Patch Set 9 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -50 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 7 chunks +121 lines, -23 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 2 chunks +43 lines, -26 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Dmitry Lomov (no reviews)
This is work in progress, in particular: - Flag for shipped features is still exposed ...
6 years, 2 months ago (2014-10-20 09:28:05 UTC) #1
Dmitry Lomov (no reviews)
This is now ready for review. Review patch set 7, patch set 8 is an ...
6 years, 2 months ago (2014-10-20 12:57:43 UTC) #2
rossberg
LGTM with comment https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h#newcode158 src/flag-definitions.h:158: V(scoping, "harmony block scoping") \ I'd ...
6 years, 2 months ago (2014-10-20 13:14:27 UTC) #3
Dmitry Lomov (no reviews)
Comments addressed, landing. https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h#newcode158 src/flag-definitions.h:158: V(scoping, "harmony block scoping") \ On ...
6 years, 2 months ago (2014-10-20 13:32:54 UTC) #4
Dmitry Lomov (no reviews)
Committed patchset #9 (id:160001) manually as 24743 (presubmit successful).
6 years, 2 months ago (2014-10-20 13:33:51 UTC) #5
adamk
6 years, 2 months ago (2014-10-20 17:44:30 UTC) #7
Message was sent while issue was closed.
Am I reading this patch right that it's simply refactoring, and not yet getting
us to a place where we can enable-by-default features that have experimental
natives?

Powered by Google App Engine
This is Rietveld 408576698