Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 642223002: history: add context menu buttons to the tab order. (Closed)

Created:
6 years, 2 months ago by Dan Beam
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

history: add context menu buttons to the tab order. Part #1 in fixing the synced devices menu. R=dmazzoni@chromium.org BUG=362424 Committed: https://crrev.com/28491bc4379c0bb4de5e0d2d591154cc5df2210f Cr-Commit-Position: refs/heads/master@{#299065}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/history/other_devices.js View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Dan Beam
there is much more to come (I've discovered quite a bit of dead code)
6 years, 2 months ago (2014-10-10 04:24:32 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/642223002/diff/1/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/642223002/diff/1/chrome/browser/resources/history/other_devices.js#newcode188 chrome/browser/resources/history/other_devices.js:188: dropDownButton.tabIndex = 0; Should this be upstreamed to ...
6 years, 2 months ago (2014-10-10 05:31:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642223002/1
6 years, 2 months ago (2014-10-10 05:31:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 06:07:17 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 06:07:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28491bc4379c0bb4de5e0d2d591154cc5df2210f
Cr-Commit-Position: refs/heads/master@{#299065}

Powered by Google App Engine
This is Rietveld 408576698