Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 642163002: Fix crash in NativeMessageProcessHost (Closed)

Created:
6 years, 2 months ago by kelvinp
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash in NativeMessageProcessHost We should initialize the |client_| pointer before launching the host process, as the OnHostProcessLaunched() callback dereferences the |client_| pointer. BUG=421500 Committed: https://crrev.com/d19b0657cafb67b266c45bac36bc4ba87a04596a Cr-Commit-Position: refs/heads/master@{#299030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kelvinp
PTAL
6 years, 2 months ago (2014-10-09 22:38:18 UTC) #3
Matt Perry
lgtm
6 years, 2 months ago (2014-10-09 22:40:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642163002/1
6 years, 2 months ago (2014-10-09 22:53:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642163002/1
6 years, 2 months ago (2014-10-10 00:32:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 01:08:31 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:04:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d19b0657cafb67b266c45bac36bc4ba87a04596a
Cr-Commit-Position: refs/heads/master@{#299030}

Powered by Google App Engine
This is Rietveld 408576698