chrome/test/base/interactive_test_utils_mac.mm - Issue 642143004: [Cocoa] Make TabContentsContainerView more testable for interactive_ui_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/interactive_test_utils_mac.mm

Issue 642143004: [Cocoa] Make TabContentsContainerView more testable for interactive_ui_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/interactive_test_utils_mac.mm

diff --git a/chrome/test/base/interactive_test_utils_mac.mm b/chrome/test/base/interactive_test_utils_mac.mm

index fcf5f124f1f1e719067dafe11595c758642694f5..424f98afd9a84143e38521cb3d1aea03b65c9b9a 100644

--- a/chrome/test/base/interactive_test_utils_mac.mm

+++ b/chrome/test/base/interactive_test_utils_mac.mm

@@ -54,6 +54,13 @@ bool IsViewFocused(const Browser* browser, ViewID vid) {

if (firstResponder == static_cast<NSResponder*>(view))

return true;

+ // Handle special case for VIEW_ID_TAB_CONTAINER. The tab container NSView

+ // always transfers first responder status to its subview, so test whether

+ // |firstResponder| is a descendant.

+ if (vid == VIEW_ID_TAB_CONTAINER &&

+ [firstResponder isKindOfClass:[NSView class]])

+ return [static_cast<NSView*>(firstResponder) isDescendantOf:view];

// Handle the special case of focusing a TextField.

if ([firstResponder isKindOfClass:[NSTextView class]]) {

NSView* delegate = static_cast<NSView*>([(NSTextView*)firstResponder