Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Issue 642143004: [Cocoa] Make TabContentsContainerView more testable for interactive_ui_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
index 3f78f802df4fffbd25b6ce03f0ceb6fc245f2014..24525c6cc86264afbf2e1e2fe0180e4040f78d5a 100644
--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
@@ -16,7 +16,6 @@
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
-#import "chrome/browser/ui/cocoa/view_id_util.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/spellcheck_messages.h"
#include "chrome/common/url_constants.h"
@@ -76,13 +75,6 @@ class SpellCheckObserver : public content::WebContentsObserver {
self = [super init];
if (self) {
renderWidgetHost_ = renderWidgetHost;
- // if |renderWidgetHost_| belongs to a BrowserPluginGuest, then it won't
- // have a view yet.
- if (renderWidgetHost_->GetView()) {
- NSView* nativeView = renderWidgetHost_->GetView()->GetNativeView();
- view_id_util::SetID(nativeView, VIEW_ID_TAB_CONTAINER);
- }
-
if (renderWidgetHost_->IsRenderView()) {
spellingObserver_.reset(
new ChromeRenderWidgetHostViewMacDelegateInternal::SpellCheckObserver(
@@ -99,10 +91,6 @@ class SpellCheckObserver : public content::WebContentsObserver {
[super dealloc];
}
-- (void)viewGone:(NSView*)view {
- view_id_util::UnsetID(view);
-}
-
// Handle an event. All incoming key and mouse events flow through this
// delegate method if implemented. Return YES if the event is fully handled, or
// NO if normal processing should take place.
« no previous file with comments | « chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698