Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 642113004: cc: Damage layer on delegated scroll (Closed)

Created:
6 years, 2 months ago by boliu
Modified:
6 years, 2 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, mkosiba (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Damage layer on delegated scroll Plumb LTHI::OnRootLayerDelegatedScrollOffsetChanged to the affected layers and properly set damage on those layers as if they have been scrolled. BUG=422061 Committed: https://crrev.com/7d5dbab6a68510344f18d4a8895157172ab5e307 Cr-Commit-Position: refs/heads/master@{#299171}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : DidScroll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M cc/layers/layer_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
boliu
PTAL. Thanks
6 years, 2 months ago (2014-10-09 22:48:43 UTC) #2
enne (OOO)
Looks good in general, but just a naming question: https://codereview.chromium.org/642113004/diff/1/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/642113004/diff/1/cc/layers/layer_impl.cc#newcode1130 cc/layers/layer_impl.cc:1130: ...
6 years, 2 months ago (2014-10-10 18:10:17 UTC) #3
boliu
https://codereview.chromium.org/642113004/diff/1/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/642113004/diff/1/cc/layers/layer_impl.cc#newcode1130 cc/layers/layer_impl.cc:1130: OnDelegatedScrollOffsetChanged(); On 2014/10/10 18:10:17, enne wrote: > bikeshed: This ...
6 years, 2 months ago (2014-10-10 18:23:11 UTC) #4
enne (OOO)
Thanks, lgtm!
6 years, 2 months ago (2014-10-10 18:23:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642113004/180001
6 years, 2 months ago (2014-10-10 18:26:36 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:180001)
6 years, 2 months ago (2014-10-10 20:05:57 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 20:07:18 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d5dbab6a68510344f18d4a8895157172ab5e307
Cr-Commit-Position: refs/heads/master@{#299171}

Powered by Google App Engine
This is Rietveld 408576698