Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 642083002: Change newly added OVERRIDE to override in //extensions (Closed)

Created:
6 years, 2 months ago by Xi Han
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change newly added OVERRIDE to override in //extensions BUG=417463 Committed: https://crrev.com/114fa843396eb4188ae1f2cf182892e36e4ea980 Cr-Commit-Position: refs/heads/master@{#298975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M extensions/shell/browser/shell_network_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xi Han
Hi Ken & Mostyn: A update of the status of the following two files in ...
6 years, 2 months ago (2014-10-09 17:18:43 UTC) #2
Mostyn Bramley-Moore
lgtm
6 years, 2 months ago (2014-10-09 17:33:24 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-09 19:46:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642083002/1
6 years, 2 months ago (2014-10-09 19:48:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 20:47:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:48:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/114fa843396eb4188ae1f2cf182892e36e4ea980
Cr-Commit-Position: refs/heads/master@{#298975}

Powered by Google App Engine
This is Rietveld 408576698