Chromium Code Reviews

Issue 642053002: [ia32] Use more efficient encoding when loading integer constants. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[ia32] Use more efficient encoding when loading integer constants. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24494

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Stats (+10 lines, -10 lines)
M src/compiler/ia32/code-generator-ia32.cc View 8 chunks +10 lines, -10 lines 0 comments

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-09 12:32:56 UTC) #1
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-09 12:37:17 UTC) #2
titzer
https://codereview.chromium.org/642053002/diff/1/src/compiler/ia32/code-generator-ia32.cc File src/compiler/ia32/code-generator-ia32.cc (right): https://codereview.chromium.org/642053002/diff/1/src/compiler/ia32/code-generator-ia32.cc#newcode555 src/compiler/ia32/code-generator-ia32.cc:555: __ xor_(reg, reg); Can you just use Move here ...
6 years, 2 months ago (2014-10-09 12:42:11 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/642053002/diff/1/src/compiler/ia32/code-generator-ia32.cc File src/compiler/ia32/code-generator-ia32.cc (right): https://codereview.chromium.org/642053002/diff/1/src/compiler/ia32/code-generator-ia32.cc#newcode555 src/compiler/ia32/code-generator-ia32.cc:555: __ xor_(reg, reg); On 2014/10/09 12:42:11, titzer wrote: > ...
6 years, 2 months ago (2014-10-09 12:47:05 UTC) #4
titzer
lgtm
6 years, 2 months ago (2014-10-09 12:49:46 UTC) #5
Benedikt Meurer
6 years, 2 months ago (2014-10-09 12:50:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24494 (presubmit successful).

Powered by Google App Engine