Issue 642053002: [ia32] Use more efficient encoding when loading integer constants.

Issue 642053002: [ia32] Use more efficient encoding when loading integer constants. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 2 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[ia32] Use more efficient encoding when loading integer constants. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24494

Patch Set 2 : Comment #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/compiler/ia32/code-generator-ia32.cc	View	1	8 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

titzer

https://codereview.chromium.org/642053002/diff/1/src/compiler/ia32/code-generator-ia32.cc File src/compiler/ia32/code-generator-ia32.cc (right): https://codereview.chromium.org/642053002/diff/1/src/compiler/ia32/code-generator-ia32.cc#newcode555 src/compiler/ia32/code-generator-ia32.cc:555: __ xor_(reg, reg); Can you just use Move here ...

6 years, 2 months ago (2014-10-09 12:42:11 UTC) #3

Benedikt Meurer

6 years, 2 months ago (2014-10-09 12:47:05 UTC) #4

Benedikt Meurer

6 years, 2 months ago (2014-10-09 12:50:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24494 (presubmit successful).

Expand Messages | Collapse Messages