Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: test/unittests/compiler/machine-operator-reducer-unittest.cc

Issue 642033002: [turbofan] Eliminate redundant masking operations for word8/word16 stores. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/unittests/compiler/graph-unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/bits.h" 5 #include "src/base/bits.h"
6 #include "src/compiler/js-graph.h" 6 #include "src/compiler/js-graph.h"
7 #include "src/compiler/machine-operator-reducer.h" 7 #include "src/compiler/machine-operator-reducer.h"
8 #include "src/compiler/typer.h" 8 #include "src/compiler/typer.h"
9 #include "test/unittests/compiler/graph-unittest.h" 9 #include "test/unittests/compiler/graph-unittest.h"
10 10
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 EXPECT_THAT(r.replacement(), 647 EXPECT_THAT(r.replacement(),
648 IsInt32Constant(base::bits::SignedSubOverflow32(x, y, &z))); 648 IsInt32Constant(base::bits::SignedSubOverflow32(x, y, &z)));
649 649
650 r = Reduce(graph()->NewNode(common()->Projection(0), add)); 650 r = Reduce(graph()->NewNode(common()->Projection(0), add));
651 ASSERT_TRUE(r.Changed()); 651 ASSERT_TRUE(r.Changed());
652 EXPECT_THAT(r.replacement(), IsInt32Constant(z)); 652 EXPECT_THAT(r.replacement(), IsInt32Constant(z));
653 } 653 }
654 } 654 }
655 } 655 }
656 656
657
658 // -----------------------------------------------------------------------------
659 // Store
660
661
662 TEST_F(MachineOperatorReducerTest, StoreRepWord8WithWord32And) {
663 const StoreRepresentation rep(kRepWord8, kNoWriteBarrier);
664 Node* const base = Parameter(0);
665 Node* const index = Parameter(1);
666 Node* const value = Parameter(2);
667 Node* const effect = graph()->start();
668 Node* const control = graph()->start();
669 TRACED_FOREACH(uint32_t, x, kUint32Values) {
670 Node* const node =
671 graph()->NewNode(machine()->Store(rep), base, index,
672 graph()->NewNode(machine()->Word32And(), value,
673 Uint32Constant(x | 0xffu)),
674 effect, control);
675
676 Reduction r = Reduce(node);
677 ASSERT_TRUE(r.Changed());
678 EXPECT_THAT(r.replacement(),
679 IsStore(rep, base, index, value, effect, control));
680 }
681 }
682
683
684 TEST_F(MachineOperatorReducerTest, StoreRepWord16WithWord32And) {
685 const StoreRepresentation rep(kRepWord16, kNoWriteBarrier);
686 Node* const base = Parameter(0);
687 Node* const index = Parameter(1);
688 Node* const value = Parameter(2);
689 Node* const effect = graph()->start();
690 Node* const control = graph()->start();
691 TRACED_FOREACH(uint32_t, x, kUint32Values) {
692 Node* const node =
693 graph()->NewNode(machine()->Store(rep), base, index,
694 graph()->NewNode(machine()->Word32And(), value,
695 Uint32Constant(x | 0xffffu)),
696 effect, control);
697
698 Reduction r = Reduce(node);
699 ASSERT_TRUE(r.Changed());
700 EXPECT_THAT(r.replacement(),
701 IsStore(rep, base, index, value, effect, control));
702 }
703 }
704
657 } // namespace compiler 705 } // namespace compiler
658 } // namespace internal 706 } // namespace internal
659 } // namespace v8 707 } // namespace v8
OLDNEW
« no previous file with comments | « test/unittests/compiler/graph-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698