Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 642033002: [turbofan] Eliminate redundant masking operations for word8/word16 stores. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate redundant masking operations for word8/word16 stores. There's no need to apply 0xff when storing 8-bit values or 0xffff when storing 16-bit values. TEST=unittests R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24492

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -45 lines) Patch
M src/compiler/machine-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 4 chunks +23 lines, -22 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 5 chunks +11 lines, -21 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-09 10:51:28 UTC) #2
titzer
https://codereview.chromium.org/642033002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/642033002/diff/1/src/compiler/machine-operator-reducer.cc#newcode484 src/compiler/machine-operator-reducer.cc:484: (rep == kRepWord16 && (m.right().Value() & 0xffff) == 0xffff))) ...
6 years, 2 months ago (2014-10-09 10:54:47 UTC) #3
titzer
lgtm
6 years, 2 months ago (2014-10-09 10:55:19 UTC) #4
Benedikt Meurer
6 years, 2 months ago (2014-10-09 12:20:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698