Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: sync/tools/sync_listen_notifications.cc

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/tools/sync_client.cc ('k') | sync/util/test_unrecoverable_error_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/tools/sync_listen_notifications.cc
diff --git a/sync/tools/sync_listen_notifications.cc b/sync/tools/sync_listen_notifications.cc
index 50040c09daaf766cf97c339c8a418865ed099698..3fa5a33afc9aabf7331f638d68daa9c988e274bc 100644
--- a/sync/tools/sync_listen_notifications.cc
+++ b/sync/tools/sync_listen_notifications.cc
@@ -52,14 +52,14 @@ const char kAllowInsecureConnectionSwitch[] = "allow-insecure-connection";
class NotificationPrinter : public InvalidationHandler {
public:
NotificationPrinter() {}
- virtual ~NotificationPrinter() {}
+ ~NotificationPrinter() override {}
- virtual void OnInvalidatorStateChange(InvalidatorState state) override {
+ void OnInvalidatorStateChange(InvalidatorState state) override {
LOG(INFO) << "Invalidator state changed to "
<< InvalidatorStateToString(state);
}
- virtual void OnIncomingInvalidation(
+ void OnIncomingInvalidation(
const ObjectIdInvalidationMap& invalidation_map) override {
ObjectIdSet ids = invalidation_map.GetObjectIds();
for (ObjectIdSet::const_iterator it = ids.begin(); it != ids.end(); ++it) {
@@ -68,9 +68,7 @@ class NotificationPrinter : public InvalidationHandler {
}
}
- virtual std::string GetOwnerName() const override {
- return "NotificationPrinter";
- }
+ std::string GetOwnerName() const override { return "NotificationPrinter"; }
private:
DISALLOW_COPY_AND_ASSIGN(NotificationPrinter);
@@ -87,7 +85,7 @@ class MyTestURLRequestContext : public net::TestURLRequestContext {
Init();
}
- virtual ~MyTestURLRequestContext() {}
+ ~MyTestURLRequestContext() override {}
};
class MyTestURLRequestContextGetter : public net::TestURLRequestContextGetter {
@@ -96,7 +94,7 @@ class MyTestURLRequestContextGetter : public net::TestURLRequestContextGetter {
const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner)
: TestURLRequestContextGetter(io_task_runner) {}
- virtual net::TestURLRequestContext* GetURLRequestContext() override {
+ net::TestURLRequestContext* GetURLRequestContext() override {
// Construct |context_| lazily so it gets constructed on the right
// thread (the IO thread).
if (!context_)
@@ -105,7 +103,7 @@ class MyTestURLRequestContextGetter : public net::TestURLRequestContextGetter {
}
private:
- virtual ~MyTestURLRequestContextGetter() {}
+ ~MyTestURLRequestContextGetter() override {}
scoped_ptr<MyTestURLRequestContext> context_;
};
« no previous file with comments | « sync/tools/sync_client.cc ('k') | sync/util/test_unrecoverable_error_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698