Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: sync/internal_api/syncapi_server_connection_manager_unittest.cc

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/syncapi_server_connection_manager_unittest.cc
diff --git a/sync/internal_api/syncapi_server_connection_manager_unittest.cc b/sync/internal_api/syncapi_server_connection_manager_unittest.cc
index 5acc6b39b1468afe1498022ddab6643d1b6abc14..10dc311832c23104d9dc10c2961467950ec0deda 100644
--- a/sync/internal_api/syncapi_server_connection_manager_unittest.cc
+++ b/sync/internal_api/syncapi_server_connection_manager_unittest.cc
@@ -25,44 +25,37 @@ using base::TimeDelta;
class BlockingHttpPost : public HttpPostProviderInterface {
public:
BlockingHttpPost() : wait_for_abort_(false, false) {}
- virtual ~BlockingHttpPost() {}
-
- virtual void SetExtraRequestHeaders(const char* headers) override {}
- virtual void SetURL(const char* url, int port) override {}
- virtual void SetPostPayload(const char* content_type,
- int content_length,
- const char* content) override {}
- virtual bool MakeSynchronousPost(int* error_code, int* response_code)
- override {
+ ~BlockingHttpPost() override {}
+
+ void SetExtraRequestHeaders(const char* headers) override {}
+ void SetURL(const char* url, int port) override {}
+ void SetPostPayload(const char* content_type,
+ int content_length,
+ const char* content) override {}
+ bool MakeSynchronousPost(int* error_code, int* response_code) override {
wait_for_abort_.TimedWait(TestTimeouts::action_max_timeout());
*error_code = net::ERR_ABORTED;
return false;
}
- virtual int GetResponseContentLength() const override {
- return 0;
- }
- virtual const char* GetResponseContent() const override {
- return "";
- }
- virtual const std::string GetResponseHeaderValue(
+ int GetResponseContentLength() const override { return 0; }
+ const char* GetResponseContent() const override { return ""; }
+ const std::string GetResponseHeaderValue(
const std::string& name) const override {
return std::string();
}
- virtual void Abort() override {
- wait_for_abort_.Signal();
- }
+ void Abort() override { wait_for_abort_.Signal(); }
private:
base::WaitableEvent wait_for_abort_;
};
class BlockingHttpPostFactory : public HttpPostProviderFactory {
public:
- virtual ~BlockingHttpPostFactory() {}
- virtual void Init(const std::string& user_agent) override {}
- virtual HttpPostProviderInterface* Create() override {
+ ~BlockingHttpPostFactory() override {}
+ void Init(const std::string& user_agent) override {}
+ HttpPostProviderInterface* Create() override {
return new BlockingHttpPost();
}
- virtual void Destroy(HttpPostProviderInterface* http) override {
+ void Destroy(HttpPostProviderInterface* http) override {
delete static_cast<BlockingHttpPost*>(http);
}
};
« no previous file with comments | « sync/internal_api/syncapi_server_connection_manager.h ('k') | sync/internal_api/test/sync_manager_for_profile_sync_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698