chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h - Issue 642023003: [fsp] Allow to create multiple observers for a directory, up to one per origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

Issue 642023003: [fsp] Allow to create multiple observers for a directory, up to one per origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments + fixed tests. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/provided_file_system.cc ('k') | chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h b/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

index 573991d9a8450aa8232b54e69e875e0489968230..14dcb98b385e4bbc617f83cedc4f6969b60b4890 100644

--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

@@ -17,6 +17,7 @@

#include "chrome/browser/chromeos/file_system_provider/observed_entry.h"

#include "chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h"

#include "storage/browser/fileapi/async_file_util.h"

+#include "url/gurl.h"

class EventRouter;

@@ -177,13 +178,16 @@ class ProvidedFileSystemInterface {

// Requests observing a directory.

virtual AbortCallback ObserveDirectory(

+ const GURL& origin,

const base::FilePath& directory_path,

bool recursive,

+ bool persistent,

const storage::AsyncFileUtil::StatusCallback& callback) = 0;

// Requests unobserving an entry, which is immediately removed from the

// internal list, hence the operation is not abortable.

virtual void UnobserveEntry(

+ const GURL& origin,

const base::FilePath& entry_path,

bool recursive,

const storage::AsyncFileUtil::StatusCallback& callback) = 0;