Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 642023002: Introduce a tsan suppressions file (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce a tsan suppressions file Also suppress a deliberate lock cycle in test-lockers BUG=none R=glider@chromium.org, machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=24484

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/run-tests.py View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/sanitizers/tsan_suppressions.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-09 09:07:14 UTC) #1
Alexander Potapenko
LGTM https://codereview.chromium.org/642023002/diff/1/tools/sanitizers/tsan_suppressions.txt File tools/sanitizers/tsan_suppressions.txt (right): https://codereview.chromium.org/642023002/diff/1/tools/sanitizers/tsan_suppressions.txt#newcode1 tools/sanitizers/tsan_suppressions.txt:1: # Suppressions for TSAN v2 s/TSAN/TSan/
6 years, 2 months ago (2014-10-09 09:18:42 UTC) #2
Michael Achenbach
LGTM
6 years, 2 months ago (2014-10-09 09:31:42 UTC) #3
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-09 09:32:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698