Issue 642003002: Move PinchViewport to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 642003002: Move PinchViewport to the Oilpan heap. (Closed)

Created:
6 years, 2 months ago by sof

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Move PinchViewport to the Oilpan heap. By having it on the heap, the FrameHost back reference can be properly accounted for during GCs. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183532

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -16 lines)			Patch
M	Source/core/frame/FrameHost.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/FrameHost.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/frame/PinchViewport.h	View	3 chunks	+15 lines, -3 lines	0 comments	Download
M	Source/core/frame/PinchViewport.cpp	View	7 chunks	+18 lines, -11 lines	0 comments	Download

Total messages: 7 (3 generated)

sof

Please take a look. (Just chasing out another off-to-on-heap reference.)

6 years, 2 months ago (2014-10-10 09:44:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642003002/1

6 years, 2 months ago (2014-10-10 09:59:54 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-10 11:10:19 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183532