Make the geolocation code use C++11 for-ranges

Make the geolocation code use C++11 for-ranges

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183865

[kenneth.r.christiansen, 2014-10-16 14:59:16]

kenneth.r.christiansen@intel.com changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-16 19:38:15]

Thanks! One comment.

https://codereview.chromium.org/641963003/diff/1/Source/modules/geolocation/G...
File Source/modules/geolocation/Geolocation.cpp (right):

https://codereview.chromium.org/641963003/diff/1/Source/modules/geolocation/G...
Source/modules/geolocation/Geolocation.cpp:244: for (GeoNotifier* notifier :
m_requestsAwaitingCachedPosition) {
As you're replacing a const_iteratore, please s/GeoNotifier*/const GeoNotifier*/
here and elsewhere.

[kenneth.christiansen, 2014-10-16 22:33:04]

kenneth.christiansen@gmail.com changed reviewers:
+ kenneth.christiansen@gmail.com

[kenneth.christiansen, 2014-10-16 22:33:05]

https://codereview.chromium.org/641963003/diff/1/Source/modules/geolocation/G...
File Source/modules/geolocation/Geolocation.cpp (right):

https://codereview.chromium.org/641963003/diff/1/Source/modules/geolocation/G...
Source/modules/geolocation/Geolocation.cpp:244: for (GeoNotifier* notifier :
m_requestsAwaitingCachedPosition) {
On 2014/10/16 at 19:38:15, Mike West wrote:
> As you're replacing a const_iteratore, please s/GeoNotifier*/const
GeoNotifier*/ here and elsewhere.

That would be a bigger change :-) I am fine to do it but involves changes other
files as well.

const_iterator on a collection of pointers means that the pointers are constant,
not the objects they point to.

Take the below, for instance:

    GeoNotifierVector::const_iterator end = notifiers.end();
    for (GeoNotifierVector::const_iterator it = notifiers.begin(); it != end;
++it)
        (*it)->runErrorCallback(error);

Here the runErrorCallback method is not declared const but it allows me to call
it anyway, that is not the case with a "for (const GeoNotifier* notifier :
notifiers)" which would bail out like this:

error: member function 'runErrorCallback' not viable: 'this' argument has type
'const blink::GeoNotifier', but function is not marked const
        notifier->runErrorCallback(error);

[kenneth.christiansen, 2014-10-16 22:44:12]

The const_iterator on a collection of pointers ensures that the collection isn't
modified (reorder elements, delete or add) while iterating. With for-ranges that
is ensured by default.

[Mike West, 2014-10-17 07:54:57]

On 2014/10/16 22:44:12, kenneth.christiansen wrote:
> The const_iterator on a collection of pointers ensures that the collection
isn't
> modified (reorder elements, delete or add) while iterating. With for-ranges
that
> is ensured by default.

Hrm. Ok. I misread something a loooooong time ago, then.

LGTM.

[kenneth.r.christiansen, 2014-10-17 08:27:10]

The CQ bit was checked by kenneth.r.christiansen@intel.com

[commit-bot: I haz the power, 2014-10-17 08:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641963003/1

[commit-bot: I haz the power, 2014-10-17 09:04:37]

Committed patchset #1 (id:1) as 183865