Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 641963002: Replace OVERRIDE and FINAL with override and final in src/apps (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in src/apps BUG=417463 Committed: https://crrev.com/c7a465643ccfff1b0292203b3edc228802f1a5be Cr-Commit-Position: refs/heads/master@{#298808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M apps/app_lifetime_monitor.h View 1 chunk +5 lines, -5 lines 0 comments Download
M apps/app_lifetime_monitor_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M apps/app_load_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/app_load_service_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M apps/app_restore_service.h View 1 chunk +6 lines, -6 lines 0 comments Download
M apps/app_restore_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/custom_launcher_page_contents.h View 1 chunk +13 lines, -13 lines 0 comments Download
M apps/load_and_launch_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/saved_files_service.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/saved_files_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/saved_files_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/ui/views/app_window_frame_view.h View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
PTAL
6 years, 2 months ago (2014-10-09 04:49:07 UTC) #2
not at google - send to devlin
lgtm
6 years, 2 months ago (2014-10-09 05:07:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641963002/1
6 years, 2 months ago (2014-10-09 05:16:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c25aae5efa58328b11ec0347f14e5b56d5171106
6 years, 2 months ago (2014-10-09 05:55:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 05:56:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7a465643ccfff1b0292203b3edc228802f1a5be
Cr-Commit-Position: refs/heads/master@{#298808}

Powered by Google App Engine
This is Rietveld 408576698