components: Introduce AlarmTimer class and use it for GCM heartbeat

google_apis/gcm/engine/mcs_client.h

Index: google_apis/gcm/engine/mcs_client.h
diff --git a/google_apis/gcm/engine/mcs_client.h b/google_apis/gcm/engine/mcs_client.h
index cc915e49087dc28829950fb34366314012fab8f3..1f17360baad86180c8580e59bc9ba56bd8832b34 100644
--- a/google_apis/gcm/engine/mcs_client.h
+++ b/google_apis/gcm/engine/mcs_client.h
@@ -12,6 +12,7 @@
 
 #include "base/files/file_path.h"
 #include "base/memory/linked_ptr.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "google_apis/gcm/base/gcm_export.h"
 #include "google_apis/gcm/base/mcs_message.h"
@@ -21,6 +22,7 @@
 
 namespace base {
 class Clock;
+class Timer;
 }  // namespace base
 
 namespace google {
@@ -98,7 +100,8 @@ class GCM_EXPORT MCSClient {
             base::Clock* clock,
             ConnectionFactory* connection_factory,
             GCMStore* gcm_store,
-            GCMStatsRecorder* recorder);
+            GCMStatsRecorder* recorder,
+            scoped_ptr<base::Timer> timer);

[Nicolas Zea, 2014/10/24 00:28:18]

nit: prefer naming this heartbeat_timer (here and in the cc file, and the
heartbeat_manager's definition)

[Chirantan Ekbote, 2014/10/24 01:04:13]

Done.

   virtual ~MCSClient();
 
   // Initialize the client. Will load any previous id/token information as well