Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: google_apis/gcm/engine/heartbeat_manager.cc

Issue 641943002: components: Introduce AlarmTimer class and use it for GCM heartbeat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make some Timer variables protected to reduce duplication, clean up comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_apis/gcm/engine/heartbeat_manager.h" 5 #include "google_apis/gcm/engine/heartbeat_manager.h"
6 6
7 #include "google_apis/gcm/protocol/mcs.pb.h" 7 #include "google_apis/gcm/protocol/mcs.pb.h"
8 #include "net/base/network_change_notifier.h" 8 #include "net/base/network_change_notifier.h"
9 9
10 #if defined(OS_CHROMEOS)
11 #include "base/timer/alarm_timer.h"
12 #endif
13
10 namespace gcm { 14 namespace gcm {
11 15
12 namespace { 16 namespace {
13 // The default heartbeat when on a mobile or unknown network . 17 // The default heartbeat when on a mobile or unknown network .
14 const int64 kCellHeartbeatDefaultMs = 1000 * 60 * 28; // 28 minutes. 18 const int64 kCellHeartbeatDefaultMs = 1000 * 60 * 28; // 28 minutes.
15 // The default heartbeat when on WiFi (also used for ethernet). 19 // The default heartbeat when on WiFi (also used for ethernet).
16 const int64 kWifiHeartbeatDefaultMs = 1000 * 60 * 15; // 15 minutes. 20 const int64 kWifiHeartbeatDefaultMs = 1000 * 60 * 15; // 15 minutes.
17 // The default heartbeat ack interval. 21 // The default heartbeat ack interval.
18 const int64 kHeartbeatAckDefaultMs = 1000 * 60 * 1; // 1 minute. 22 const int64 kHeartbeatAckDefaultMs = 1000 * 60 * 1; // 1 minute.
19 } // namespace 23 } // namespace
20 24
21 HeartbeatManager::HeartbeatManager() 25 HeartbeatManager::HeartbeatManager()
22 : waiting_for_ack_(false), 26 : waiting_for_ack_(false),
23 heartbeat_interval_ms_(0), 27 heartbeat_interval_ms_(0),
24 server_interval_ms_(0), 28 server_interval_ms_(0),
25 heartbeat_timer_(true /* retain user task */, 29 #if defined(OS_CHROMEOS)
26 false /* not repeating */), 30 heartbeat_timer_(new base::AlarmTimer(true /* retain user task */,
31 false /* not repeating */)),
32 #else
33 heartbeat_timer_(new base::Timer(true /* retain user task */,
34 false /* not repeating */)),
35 #endif
27 weak_ptr_factory_(this) {} 36 weak_ptr_factory_(this) {}
28 37
29 HeartbeatManager::~HeartbeatManager() {} 38 HeartbeatManager::~HeartbeatManager() {}
30 39
31 void HeartbeatManager::Start( 40 void HeartbeatManager::Start(
32 const base::Closure& send_heartbeat_callback, 41 const base::Closure& send_heartbeat_callback,
33 const base::Closure& trigger_reconnect_callback) { 42 const base::Closure& trigger_reconnect_callback) {
34 DCHECK(!send_heartbeat_callback.is_null()); 43 DCHECK(!send_heartbeat_callback.is_null());
35 DCHECK(!trigger_reconnect_callback.is_null()); 44 DCHECK(!trigger_reconnect_callback.is_null());
36 send_heartbeat_callback_ = send_heartbeat_callback; 45 send_heartbeat_callback_ = send_heartbeat_callback;
37 trigger_reconnect_callback_ = trigger_reconnect_callback; 46 trigger_reconnect_callback_ = trigger_reconnect_callback;
38 47
39 // Kicks off the timer. 48 // Kicks off the timer.
40 waiting_for_ack_ = false; 49 waiting_for_ack_ = false;
41 RestartTimer(); 50 RestartTimer();
42 } 51 }
43 52
44 void HeartbeatManager::Stop() { 53 void HeartbeatManager::Stop() {
45 heartbeat_timer_.Stop(); 54 heartbeat_timer_->Stop();
46 waiting_for_ack_ = false; 55 waiting_for_ack_ = false;
47 } 56 }
48 57
49 void HeartbeatManager::OnHeartbeatAcked() { 58 void HeartbeatManager::OnHeartbeatAcked() {
50 if (!heartbeat_timer_.IsRunning()) 59 if (!heartbeat_timer_->IsRunning())
51 return; 60 return;
52 61
53 DCHECK(!send_heartbeat_callback_.is_null()); 62 DCHECK(!send_heartbeat_callback_.is_null());
54 DCHECK(!trigger_reconnect_callback_.is_null()); 63 DCHECK(!trigger_reconnect_callback_.is_null());
55 waiting_for_ack_ = false; 64 waiting_for_ack_ = false;
56 RestartTimer(); 65 RestartTimer();
57 } 66 }
58 67
59 void HeartbeatManager::UpdateHeartbeatConfig( 68 void HeartbeatManager::UpdateHeartbeatConfig(
60 const mcs_proto::HeartbeatConfig& config) { 69 const mcs_proto::HeartbeatConfig& config) {
61 if (!config.IsInitialized() || 70 if (!config.IsInitialized() ||
62 !config.has_interval_ms() || 71 !config.has_interval_ms() ||
63 config.interval_ms() <= 0) { 72 config.interval_ms() <= 0) {
64 return; 73 return;
65 } 74 }
66 DVLOG(1) << "Updating heartbeat interval to " << config.interval_ms(); 75 DVLOG(1) << "Updating heartbeat interval to " << config.interval_ms();
67 server_interval_ms_ = config.interval_ms(); 76 server_interval_ms_ = config.interval_ms();
68 } 77 }
69 78
70 base::TimeTicks HeartbeatManager::GetNextHeartbeatTime() const { 79 base::TimeTicks HeartbeatManager::GetNextHeartbeatTime() const {
71 if (heartbeat_timer_.IsRunning()) 80 if (heartbeat_timer_->IsRunning())
72 return heartbeat_timer_.desired_run_time(); 81 return heartbeat_timer_->desired_run_time();
73 else 82 else
74 return base::TimeTicks(); 83 return base::TimeTicks();
75 } 84 }
76 85
77 void HeartbeatManager::OnHeartbeatTriggered() { 86 void HeartbeatManager::OnHeartbeatTriggered() {
78 if (waiting_for_ack_) { 87 if (waiting_for_ack_) {
79 LOG(WARNING) << "Lost connection to MCS, reconnecting."; 88 LOG(WARNING) << "Lost connection to MCS, reconnecting.";
80 Stop(); 89 Stop();
81 trigger_reconnect_callback_.Run(); 90 trigger_reconnect_callback_.Run();
82 return; 91 return;
(...skipping 19 matching lines...) Expand all
102 // For unknown connections, use the longer cellular heartbeat interval. 111 // For unknown connections, use the longer cellular heartbeat interval.
103 heartbeat_interval_ms_ = kCellHeartbeatDefaultMs; 112 heartbeat_interval_ms_ = kCellHeartbeatDefaultMs;
104 } 113 }
105 DVLOG(1) << "Sending next heartbeat in " 114 DVLOG(1) << "Sending next heartbeat in "
106 << heartbeat_interval_ms_ << " ms."; 115 << heartbeat_interval_ms_ << " ms.";
107 } else { 116 } else {
108 heartbeat_interval_ms_ = kHeartbeatAckDefaultMs; 117 heartbeat_interval_ms_ = kHeartbeatAckDefaultMs;
109 DVLOG(1) << "Resetting timer for ack with " 118 DVLOG(1) << "Resetting timer for ack with "
110 << heartbeat_interval_ms_ << " ms interval."; 119 << heartbeat_interval_ms_ << " ms interval.";
111 } 120 }
112 heartbeat_timer_.Start(FROM_HERE, 121 heartbeat_timer_->Start(FROM_HERE,
113 base::TimeDelta::FromMilliseconds( 122 base::TimeDelta::FromMilliseconds(
114 heartbeat_interval_ms_), 123 heartbeat_interval_ms_),
115 base::Bind(&HeartbeatManager::OnHeartbeatTriggered, 124 base::Bind(&HeartbeatManager::OnHeartbeatTriggered,
116 weak_ptr_factory_.GetWeakPtr())); 125 weak_ptr_factory_.GetWeakPtr()));
117 } 126 }
118 127
119 } // namespace gcm 128 } // namespace gcm
OLDNEW
« google_apis/gcm/engine/heartbeat_manager.h ('K') | « google_apis/gcm/engine/heartbeat_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698